Menu ▾ ▴

#501 The file tree does sometimes not update correspondingly

v1.1.x
fixed
Erik Hänel
None
v1.1.2
Bug Fix
2020-03-31
2019-12-11
Erik Hänel
No

The file tree is sometimes not updated correspondingly (esp. if a new file had been created). This has to be investigated.

Analysis:

There are two issues in this case: the first one is that wxFileName::GetModificationTime() can only access file times of readable file, so one has to check in advance, whether the current modified file is readable. Second, it seems that the reload flag array is too small and ignores the reload information relating the plotting path. This might explain the weird behavior primary observed together with created plots.

Implementation:

  • Implementation: The fix was implemented as proposed by the analysis.
  • Revision: [r681]
  • Implementation test: Files were created in every root path. The file tree got refreshed everytime.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

This fix was tested in productive environment. No deviatons detected. Bug fix sucessful.

Related

Commit: [r681]

Discussion

  • Erik Hänel

    Erik Hänel - 2019-12-11
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2020-01-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The file tree is sometimes not updated correspondingly (esp. if a new file had been created). This has to be investigated.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2020-01-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The file tree is sometimes not updated correspondingly (esp. if a new file had been created). This has to be investigated.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+There are two issues in this case: the first one is that `wxFileName::GetModificationTime()` can only access file times of readable file, so one has to check in advance, whether the current modified file is readable. Second, it seems that the reload flag array is too small and ignores the reload information relating the plotting path. This might explain the weird behavior primary observed together with created plots.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2020-01-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 There are two issues in this case: the first one is that `wxFileName::GetModificationTime()` can only access file times of readable file, so one has to check in advance, whether the current modified file is readable. Second, it seems that the reload flag array is too small and ignores the reload information relating the plotting path. This might explain the weird behavior primary observed together with created plots.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was implemented as proposed by the analysis.
+* Revision: [r681]
+* Implementation test: Files were created in every root path. The file tree got refreshed everytime.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r681]

  • Erik Hänel

    Erik Hänel - 2020-03-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested in productive environment. No deviatons detected. Bug fix sucessful.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB