Menu ▾ ▴

#498 lclfunc cannot handle linebreaks

v1.1.x
fixed
Erik Hänel
None
v1.1.2
Bug Fix
2019-12-11
2019-12-06
Erik Hänel
No

The command lclfunc cannot handle definitions spread along multiple lines using the \\ operator.

Analysis:

This issue is solely present in the Script class, because the Procedure class gets its command line preprocessed from the ProcedureLibrary . The issue may be fixed by first connect the broken lines into a single line, before the lclfunc command is applied.

Implementation:

  • Implementation: The fix was processed as proposed by the analysis.
  • Revision: [r670]
  • Implementation test: lclfunc was used in the current and in an included script together with line breaks.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

This fix was tested manually and added to the automatic SW tests as well. No deviations detected.

Related

Commit: [r670]

Discussion

  • Erik Hänel

    Erik Hänel - 2019-12-06
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-12-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The command `lclfunc` cannot handle definitions spread along multiple lines using the `\\` operator.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2019-12-07
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The command `lclfunc` cannot handle definitions spread along multiple lines using the `\\` operator.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This issue is solely present in the `Script` class, because the `Procedure` class gets its command line preprocessed from the `ProcedureLibrary` . The issue may be fixed by first connect the broken lines into a single line, before the `lclfinc` command is applied.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-12-07
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,23 +1,23 @@
 The command `lclfunc` cannot handle definitions spread along multiple lines using the `\\` operator.

 ###Analysis:
-This issue is solely present in the `Script` class, because the `Procedure` class gets its command line preprocessed from the `ProcedureLibrary` . The issue may be fixed by first connect the broken lines into a single line, before the `lclfinc` command is applied.
+This issue is solely present in the `Script` class, because the `Procedure` class gets its command line preprocessed from the `ProcedureLibrary` . The issue may be fixed by first connect the broken lines into a single line, before the `lclfunc` command is applied.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was processed as proposed by the analysis.
+* Revision: [r670]
+* Implementation test: `lclfunc` was used in the current and in an included script together with line breaks.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r670]

  • Erik Hänel

    Erik Hänel - 2019-12-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested manually and added to the automatic SW tests as well. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB