Menu ▾ ▴

#441 Renaming - Warning in case the new variable is already in use

v1.1.x
closed
Erik Hänel
None
v1.1.2
New Functionality
2019-08-21
2019-02-11
Rudolf Brausemann
No

I reckon it would be helpful, if there would be displayed warning on the renaming window, if you try to rename a variable into something already in use during within the function.

Analysis:

This can be achieved quite simple by injecting a call to FindAll() with the correct style and evaluating the length of the returned vector right before the actual algorithm replaces all matches. Add a message box, if the length of the returned vector is non-zero.

Implementation:

  • Implementation: The new functionality was implemented as proposed by the analysis.
  • Revision: [r481]
  • Implementation test: Different symbols were tried to be renamed without deviation.

Documentation:

  • ChangesLog: Updated
  • Comments: Changed function was commented
  • Documentation articles: Not needed
  • Language files: The language strings for the new message box were created.

Tests:

This functionality was tested manually. No deviation occured.

Related

Commit: [r481]

Discussion

  • Erik Hänel

    Erik Hänel - 2019-02-11
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-02-13
    • Version: v1.1.1 --> v1.1.2
     

  • Erik Hänel

    Erik Hänel - 2019-02-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 I reckon it would be helpful, if there would be displayed warning on the renaming window, if you try to rename a variable into something already in use during within the function.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2019-02-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 I reckon it would be helpful, if there would be displayed warning on the renaming window, if you try to rename a variable into something already in use during within the function.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This can be achieved quite simple by injecting a call to `FindAll()` with the correct style and evaluating the length of the returned `vector` right before the actual algorithm replaces all matches. Add a message box, if the length of the returned `vector` is non-zero.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-02-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 This can be achieved quite simple by injecting a call to `FindAll()` with the correct style and evaluating the length of the returned `vector` right before the actual algorithm replaces all matches. Add a message box, if the length of the returned `vector` is non-zero.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The new functionality was implemented as proposed by the analysis.
+* Revision: [r481]
+* Implementation test: Different symbols were tried to be renamed without deviation.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: Updated
+* Comments: Changed function was commented
+* Documentation articles: Not needed
+* Language files: The language strings for the new message box were created.

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r481]

  • Erik Hänel

    Erik Hänel - 2019-08-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: The language strings for the new message box were created.

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This functionality was tested manually. No deviation occured.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB