Menu ▾ ▴

#436 Text - Remove marking

v1.1.x
fixed
Erik Hänel
None
v1.1.1
Bug Fix
2019-08-19
2019-02-08
Rudolf Brausemann
No

Wenn man im Moment Text permanent markiert, dann kann man das nicht rückgängig machen, außer alle instanzen umzubennnen, oder neuzustarten - über Kontextmenü tooglebar machen?

Analysis:

To change the behavior of the context menu entry, change the behavior in the corresponding member function of the editor: NumeReEditor::OnDisplayVariable(). Change it so that it toggles the highlighting effect. This can be done by using the private member variable m_watchedString, which stores the identfier, which was highlighted last. If the names are identical, then only the indicators are cleared.

Implementation:

  • Implementation: The fix was implemented as proposed by the analysis.
  • Revision: [r464]
  • Implementation test: The permanent highlighting was applied and removed again without any deviations.

Documentation:

  • ChangesLog: updated
  • Comments: The changed functions were commented sufficiently
  • Documentation articles: Not needed
  • Language files: Not needed

Tests:

Bug fix was tested in productive environment. No deviations detected.

Related

Commit: [r464]

Discussion

  • Erik Hänel

    Erik Hänel - 2019-02-08
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-02-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 Wenn man im Moment Text permanent markiert, dann kann man das nicht rückgängig machen, außer alle instanzen umzubennnen, oder neuzustarten - über Kontextmenü tooglebar machen?
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2019-02-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Wenn man im Moment Text permanent markiert, dann kann man das nicht rückgängig machen, außer alle instanzen umzubennnen, oder neuzustarten - über Kontextmenü tooglebar machen?

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+To change the behavior of the context menu entry, change the behavior in the corresponding member function of the editor: `NumeReEditor::OnDisplayVariable()`. Change it so that it toggles the highlighting effect. This can be done by using the private member variable `m_watchedString`, which stores the identfier, which was highlighted last. If the names are identical, then only the indicators are cleared.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-02-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 To change the behavior of the context menu entry, change the behavior in the corresponding member function of the editor: `NumeReEditor::OnDisplayVariable()`. Change it so that it toggles the highlighting effect. This can be done by using the private member variable `m_watchedString`, which stores the identfier, which was highlighted last. If the names are identical, then only the indicators are cleared.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was implemented as proposed by the analysis.
+* Revision: [r464]
+* Implementation test: The permanent highlighting was applied and removed again without any deviations.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: The changed functions were commented sufficiently
+* Documentation articles: Not needed
+* Language files: Not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r464]

  • Erik Hänel

    Erik Hänel - 2019-08-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Bug fix was tested in productive environment. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB