Menu ▾ ▴

#427 Install sections cannot be executed

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.1
Bug Fix
2019-01-26
2018-12-19
Erik Hänel
No

The install sections of scripts cannot be executed.

Analysis:

There is a little issue with a substr in line 348 in script.cpp. The following line

sScriptCommand += " " + sTemp.substr(0, sTemp.find("<endinfo>"));

should be

sScriptCommand += " " + sTemp.substr(0, sTemp.find("<endinfo>") + 9);

Implementation:

  • Implementation: The fix was processed as indicated by the analysis.
  • Revision: [r448]
  • Implementation test: An install section was executed without any deviation.

Documentation:

  • ChangesLog: Updated
  • Comments: Not needed
  • Documentation articles: not needed
  • Language files: Not needed

Tests:

This fix was tested manually. No deviations occured. Bug fix implemented successfully.

Related

Commit: [r448]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-12-19
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-12-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 The install sections of scripts cannot be executed.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-12-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,15 @@
 The install sections of scripts cannot be executed.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+There is a little issue with a `substr` in line 348 in script.cpp. The following line
+

+    :::C++
+    sScriptCommand += " " + sTemp.substr(0, sTemp.find("<endinfo>"));
+    
+should be
+
+    :::C++
+    sScriptCommand += " " + sTemp.substr(0, sTemp.find("<endinfo>") + 9);

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-12-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -12,15 +12,15 @@
     sScriptCommand += " " + sTemp.substr(0, sTemp.find("<endinfo>") + 9);

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was processed as indicated by the analysis.
+* Revision: [r448]
+* Implementation test: An install section was executed without any deviation.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: Updated
+* Comments: Not needed
+* Documentation articles: not needed
+* Language files: Not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r448]

  • Erik Hänel

    Erik Hänel - 2019-01-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -23,4 +23,4 @@

 * Language files: Not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested manually. No deviations occured. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB