Menu ▾ ▴

#418 Add more smoothing methods

v1.1.x
closed
Erik Hänel
None
v1.1.2
New Functionality
2020-11-09
2018-12-02
Erik Hänel
No

Add more smoothing methods like Savitzky-Golay (see https://en.wikipedia.org/wiki/Savitzky%E2%80%93Golay_filter and http://www.statistics4u.info/fundstat_germ/cc_savgol_coeff.html)

Analysis:

The whole smoothing functionality has to be adapted. A reasonable functionality change would be to implement an abstract filter and to specialize it depending on the selected smoothing method. This will require a bunch of logic changes in the existing algorithm. The benefit will be, that new filters may be implemented quite easily.

Implementation:

  • Implementation: The implementation was done as proposed by the analysis.
  • Revision: [r742], [r744] & [r745]
  • Implementation test: All three new filters have been tested in one and two dimensions.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [x] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [ ] not needed
  • Language files:
    • [x] corresponding language files updated
    • [ ] not needed

Tests:

New functionality was added to the automatic SW tests. No deviations detected.

Related

Commit: [r742]
Commit: [r744]
Commit: [r745]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-12-02
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2020-07-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Add more smoothing methods like Savitzky-Golay (see https://en.wikipedia.org/wiki/Savitzky%E2%80%93Golay_filter and http://www.statistics4u.info/fundstat_germ/cc_savgol_coeff.html)
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2020-07-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Add more smoothing methods like Savitzky-Golay (see https://en.wikipedia.org/wiki/Savitzky%E2%80%93Golay_filter and http://www.statistics4u.info/fundstat_germ/cc_savgol_coeff.html)

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The whole smoothing functionality has to be adapted. A reasonable functionality change would be to implement an abstract filter and to specialize it depending on the selected smoothing method. This will require a bunch of logic changes in the existing algorithm. The benefit will be, that new filters may be implemented quite easily.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2020-07-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,19 +4,19 @@
 The whole smoothing functionality has to be adapted. A reasonable functionality change would be to implement an abstract filter and to specialize it depending on the selected smoothing method. This will require a bunch of logic changes in the existing algorithm. The benefit will be, that new filters may be implemented quite easily.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The implementation was done as proposed by the analysis.
+* Revision: [r742], [r744] & [r745]
+* Implementation test: All three new filters have been tested in one and two dimensions.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
-    * [ ] corresponding language files updated
+    * [x] corresponding language files updated
     * [ ] not needed

 ###Tests:
    • status: implementing --> testing
     

    Related

    Commit: [r742]
    Commit: [r744]
    Commit: [r745]

  • Erik Hänel

    Erik Hänel - 2020-11-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [ ] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+New functionality was added to the automatic SW tests. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB