Menu ▾ ▴

#415 The 'cmp()' function cannot be used

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.1
Bug Fix
2019-01-26
2018-11-30
Erik Hänel
No

The cmp() function cannot be used with datasets. It will return more than one value, where most are equal to nan.

Analysis:

This issue was introduced with a fix for the implementation of ticket [#326]. This fix is specialized for standard MAFs like max(), but not for cmp() and pct(). These won't be executed correctly. The introduced condition in line 479 in dataaccess.cpp has to be adapted, so that it can cope with both types of MAFs.

Implementation:

  • Implementation: The fix was processed as indicated by the analysis. Additionally, a bug was resolved, which lead to an issue if two caches share the same last part of their names.
  • Revision: [r437]
  • Implementation test: The erroneous lines were executed without any deviation.

Documentation:

  • ChangesLog: updated
  • Comments: The changed sections were commented
  • Documentation articles: Not needed
  • Language files: Not needed

Tests:

Fix was added to the automatic tests. No deviations occured. Bug fix implemented successfully.

Related

Commit: [r437]
Tickets: #326

Discussion

  • Erik Hänel

    Erik Hänel - 2018-11-30
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-11-30
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 The `cmp()` function cannot be used with datasets. It will return more than one value, where most are equal to `nan`.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-11-30
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The `cmp()` function cannot be used with datasets. It will return more than one value, where most are equal to `nan`.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This issue was introduced with a fix for the implementation of ticket [#326]. This fix is specialized for standarf MAFs like `max()`, but not for `cmp()` and `pct()`. These won't be executed correctly. The introduced condition in line 479 in dataaccess.cpp has to be adapted, so that it can cope with both types of MAFs.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

    Related

    Tickets: #326

  • Erik Hänel

    Erik Hänel - 2018-12-01
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,18 +1,18 @@
 The `cmp()` function cannot be used with datasets. It will return more than one value, where most are equal to `nan`.

 ###Analysis:
-This issue was introduced with a fix for the implementation of ticket [#326]. This fix is specialized for standarf MAFs like `max()`, but not for `cmp()` and `pct()`. These won't be executed correctly. The introduced condition in line 479 in dataaccess.cpp has to be adapted, so that it can cope with both types of MAFs.
+This issue was introduced with a fix for the implementation of ticket [#326]. This fix is specialized for standard MAFs like `max()`, but not for `cmp()` and `pct()`. These won't be executed correctly. The introduced condition in line 479 in dataaccess.cpp has to be adapted, so that it can cope with both types of MAFs.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was processed as indicated by the analysis. Additionally, a bug was resolved, which lead to an issue if two caches share the same last part of their names.
+* Revision: [r437]
+* Implementation test: The erroneous lines were executed without any deviation.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: The changed sections were commented
+* Documentation articles: Not needed
+* Language files: Not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r437]
    Tickets: #326

  • Erik Hänel

    Erik Hänel - 2019-01-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix was added to the automatic tests. No deviations occured. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB