Menu ▾ ▴

#414 'smooth' has problems with single-column data sets

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.1
Bug Fix
2019-01-26
2018-11-29
Erik Hänel
No

If one wants to apply smooth to a single-column data set and doesn't specify the direction, the autodetect feature doesn't work.

Analysis:

The issue is simple: the border case checks determine whether the order does not fit to the dimensions of the table before the autodetect feature is applied. To fix simply move the dimension checks after the autodetect feature.

Implementation:

  • Implementation: The fix was applied as proposed by the analysis.
  • Revision: [r436]
  • Implementation test: smooth was applied to a single-column data set without any deviation.

Documentation:

  • ChangesLog: updated
  • Comments: Comments were added
  • Documentation articles: Not needed
  • Language files: Not needed

Tests:

Fix was added to the automatic tests. No deviations occured. Bug fix implemented successfully.

Related

Commit: [r436]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-11-29
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-11-29
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 If one wants to apply `smooth` to a single-column data set and doesn't specify the direction, the autodetect feature doesn't work.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-11-29
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 If one wants to apply `smooth` to a single-column data set and doesn't specify the direction, the autodetect feature doesn't work.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The issue is simple: the border case checks determine whether the order does not fit to the dimensions of the table *before* the autodetect feature is applied. To fix simply move the dimension checks *after* the autodetect feature.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-11-29
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 The issue is simple: the border case checks determine whether the order does not fit to the dimensions of the table *before* the autodetect feature is applied. To fix simply move the dimension checks *after* the autodetect feature.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was applied as proposed by the analysis.
+* Revision: [r436]
+* Implementation test: `smooth` was applied to a single-column data set without any deviation.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: Comments were added
+* Documentation articles: Not needed
+* Language files: Not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r436]

  • Erik Hänel

    Erik Hänel - 2019-01-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix was added to the automatic tests. No deviations occured. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB