Menu ▾ ▴

#408 'plot' doesn't create target folders, if needed

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.1
Bug Fix
2019-01-23
2018-11-26
Erik Hänel
No

The command plot doesn't create the target folder of a output file, although it doesn't throw an corresponding error, which informs the user that the target file path does not exist.

Analysis:

This can be fixed by adding a new member function to the FileSystem class: ValidizeAndPrepareName(), which will create the missing folders on-the-fly.

Implementation:

  • Implementation: The fix was processed as proposed by the analysis.
  • Revision: [r431]
  • Implementation test: A plot was created in a new, non-existent folder. The folder was created on-the-fly

Documentation:

  • ChangesLog: updated
  • Comments: New member functions were commented
  • Documentation articles: Not needed
  • Language files: Not needed

Tests:

This was added to the automatic SW tests. Tests did run without any deviation.

Related

Commit: [r431]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-11-26
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-11-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 The command `plot` doesn't create the target folder of a output file, although it doesn't throw an corresponding error, which informs the user that the target file path does not exist.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-11-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The command `plot` doesn't create the target folder of a output file, although it doesn't throw an corresponding error, which informs the user that the target file path does not exist.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This can be fixed by adding a new member function to the `FileSystem` class: `ValidizeAndPrepareName()`, which will create the missing folders on-the-fly.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-11-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 This can be fixed by adding a new member function to the `FileSystem` class: `ValidizeAndPrepareName()`, which will create the missing folders on-the-fly.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was processed as proposed by the analysis.
+* Revision: [r431]
+* Implementation test: A plot was created in a new, non-existent folder. The folder was created on-the-fly

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: New member functions were commented
+* Documentation articles: Not needed
+* Language files: Not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r431]

  • Erik Hänel

    Erik Hänel - 2019-01-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This was added to the automatic SW tests. Tests did run without any deviation.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB