Menu ▾ ▴

#407 'fft cache(:,1:2)' doesn't work

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.1
Bug Fix
2019-01-23
2018-11-23
Erik Hänel
No

The command sequence

fft cache(:,1:2)

doesn't work and throws an error, that the cache cache() already exists. There's probably an issue in parser_evalTargetExpression().

Analysis:

The issue is that in the function Table copyAndExtract() one tries to rename the cache "cache" into "cache" in this case. This is not possible. So the fix is as simple as this: add 

if (sDatatable != "cache")
    _cache.renameCache("cache", sDatatable, true);

to the mentioned function.

Implementation:

  • Implementation: The fix was applied as proposed by the analysis.
  • Revision: [r428]
  • Implementation test: The command line was executed without any deviation.

Documentation:

  • ChangesLog: updated
  • Comments: not needed
  • Documentation articles: not needed
  • Language files: not needed

Tests:

The fix was added to the automatic tests. No deviations occured. Bug fix implemented successfully.

Related

Commit: [r428]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-11-23
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-11-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -3,3 +3,20 @@
     fft cache(:,1:2)

 doesn't work and throws an error, that the cache `cache()` already exists. There's probably an issue in  `parser_evalTargetExpression()`.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-11-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -5,7 +5,13 @@
 doesn't work and throws an error, that the cache `cache()` already exists. There's probably an issue in  `parser_evalTargetExpression()`.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The issue is that in the function `Table copyAndExtract()` one tries to rename the cache `"cache"` into `"cache"` in this case. This is not possible. So the fix is as simple as this: add 
+

+    :::C++
+    if (sDatatable != "cache")
+        _cache.renameCache("cache", sDatatable, true);
+
+to the mentioned function.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-11-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -14,15 +14,15 @@
 to the mentioned function.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was applied as proposed by the analysis.
+* Revision: [r428]
+* Implementation test: The command line was executed without any deviation.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: not needed
+* Documentation articles: not needed
+* Language files: not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r428]

  • Erik Hänel

    Erik Hänel - 2019-01-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -25,4 +25,4 @@

 * Language files: not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+The fix was added to the automatic tests. No deviations occured. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB