Menu ▾ ▴

#389 Rework complex return values in 'matop' mode

v1.1.x
closed
Erik Hänel
None
v1.1.1
Change Request
2018-11-16
2018-10-20
Erik Hänel
No

If the return value in matop mode is complex, then the values are often composed in two neighbouring diagonals in the same matrix. Change that to return two neighbouring square matrices, with one returning the real and one returning the imaginary parts of the result. This allows the user to select the real values direclty by writing

matop someMatrix() = [4x4 matrix];
matop realVal() = diag(someMatrix())(:,1:4)

Analysis:

This change requires modifications in the functions parser_calcEigenVects() and parser_makeReal(). Additionally the documentation article concerning matrix functions and the corresponding language strings have to be adapted.

Implementation:

  • Implementation: The change was done as proposed by the analysis.
  • Revision: [r407]
  • Implementation test: Matrices with real and complex return values were tested without any deviation

Documentation:

  • ChangesLog: updated
  • Comments: The functions were commented sufficiently
  • Documentation articles: updated correspondingly
  • Language files: updated correspondingly

Tests:

This change was added to the automatic SW tests. No deviations detected.

Related

Commit: [r407]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-10-21
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-10-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -2,3 +2,20 @@

     matop someMatrix() = [4x4 matrix];
     matop realVal() = diag(someMatrix())(:,1:4)

+    
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-10-27
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,7 @@
     matop realVal() = diag(someMatrix())(:,1:4)

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This change requires modifications in the functions `parser_calcEigenVects()` and `parser_makeReal()`. Additionally the documentation article concerning matrix functions and the corresponding language strings have to be adapted.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-10-27
    • summary: Rework complex return values in ' matop' mode --> Rework complex return values in 'matop' mode
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -7,15 +7,15 @@
 This change requires modifications in the functions `parser_calcEigenVects()` and `parser_makeReal()`. Additionally the documentation article concerning matrix functions and the corresponding language strings have to be adapted.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The change was done as proposed by the analysis.
+* Revision: [r407]
+* Implementation test: Matrices with real and complex return values were tested without any deviation

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: The functions were commented sufficiently
+* Documentation articles: updated correspondingly
+* Language files: updated correspondingly

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r407]

  • Erik Hänel

    Erik Hänel - 2018-11-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -18,4 +18,4 @@

 * Language files: updated correspondingly

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This change was added to the automatic SW tests. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB