Menu ▾ ▴

#387 Rename functions

v1.1.x
closed
Erik Hänel
None
v1.1.1
Change Request
2018-11-11
2018-10-20
Erik Hänel
No

Rename the following functions:

  • faculty() with factorial()
  • dblfacul() with dblfact()
  • trace() with line() and tracev() with linev() in draw mode

Analysis:

faculty() and dblfacul() are renamed in the functionimplementations.cpp file easily. The functions trace() and tracev() have to be implemented in the plotting.cpp. Finally, the language strings, the find database and the documentation articles concerning draw and draw3d have to be updated. Of course, due to legacy code, the old names will be supported as well, however, they won't be highlighted in the editor any longer.

Implementation:

  • Implementation: The change was processed as proposed by the analysis.
  • Revision: [r403]
  • Implementation test: Styling and tooltips were tested. The functionality will be tested in the SW test.

Documentation:

  • ChangesLog: updated
  • Comments: Not needed - only name change
  • Documentation articles: updated as proposed by the analysis
  • Language files: updated as proposed by the analysis

Tests:

This change was tested in the automatic SW tests. No deviations detected.

Related

Commit: [r403]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-10-21
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-10-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -3,3 +3,20 @@

 * `faculty()` with `factorial()`
 * `dblfacul()` with `dblfact()`
 * `trace()` with `line()` and `tracev()` with `linev()` in draw mode
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-10-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -5,7 +5,7 @@

 * `trace()` with `line()` and `tracev()` with `linev()` in draw mode

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+`faculty()` and `dblfacul()` are renamed in the functionimplementations.cpp file easily. The functions `trace()` and `tracev()` have to be implemented in the plotting.cpp. Finally, the language strings, the find database and the documentation articles concerning `draw` and `draw3d` have to be updated. Of course, due to legacy code, the old names will be supported as well, however, they won't be highlighted in the editor any longer.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-10-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -8,15 +8,15 @@
 `faculty()` and `dblfacul()` are renamed in the functionimplementations.cpp file easily. The functions `trace()` and `tracev()` have to be implemented in the plotting.cpp. Finally, the language strings, the find database and the documentation articles concerning `draw` and `draw3d` have to be updated. Of course, due to legacy code, the old names will be supported as well, however, they won't be highlighted in the editor any longer.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The change was processed as proposed by the analysis.
+* Revision: [r403]
+* Implementation test: Styling and tooltips were tested. The functionality will be tested in the SW test.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: Not needed - only name change
+* Documentation articles: updated as proposed by the analysis
+* Language files: updated as proposed by the analysis

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r403]

  • Erik Hänel

    Erik Hänel - 2018-11-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -19,4 +19,4 @@

 * Language files: updated as proposed by the analysis

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This change was tested in the automatic SW tests. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB