Menu ▾ ▴

#382 Use semicolons in loops like everywhere

v1.1.x
closed
Erik Hänel
None
v1.1.1
Change Request
2018-11-10
2018-10-10
Erik Hänel
No

Currently, semicolons are not necessary in loops to suppress printing the results. Change this behavior to make it more consistent to the way it's done outside of loops. This can probably be done together with the implementation of [#379].

Analysis:

The FlowCtrl class has to handle semicolons. The needed boolean flag is already available. In addition the semicolons have the be appended again in Procedure::ProcCalc and NumeReKernel::handleFlowControls if the suppress flag is set.

Implementation:

  • Implementation: The change was done as proposed by the analysis
  • Revision: [r400]
  • Implementation test: Tests were performed with and without semicolons in loops. The expressions were numerical and string expressions

Documentation:

  • ChangesLog: updated
  • Comments: The changed sections were commented
  • Documentation articles: Not needed - intended behavior
  • Language files: Not needed

Tests:

This change was tested thoroughly in production and durability tests. All deviations were fixed.

Related

Commit: [r400]
Tickets: #379

Discussion

  • Erik Hänel

    Erik Hänel - 2018-10-10
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-10-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 Currently, semicolons are not necessary in loops to suppress printing the results. Change this behavior to make it more consistent to the way it's done outside of loops. This can probably be done together with the implementation of [#379].
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

    Related

    Tickets: #379

  • Erik Hänel

    Erik Hänel - 2018-10-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Currently, semicolons are not necessary in loops to suppress printing the results. Change this behavior to make it more consistent to the way it's done outside of loops. This can probably be done together with the implementation of [#379].

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The `FlowCtrl` class has to handle semicolons. The needed boolean flag is already available. In addition the semicolons have the be appended again in `Procedure::ProcCalc` and `NumeReKernel::handleFlowControls` if the suppress flag is set.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

    Related

    Tickets: #379

  • Erik Hänel

    Erik Hänel - 2018-10-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 The `FlowCtrl` class has to handle semicolons. The needed boolean flag is already available. In addition the semicolons have the be appended again in `Procedure::ProcCalc` and `NumeReKernel::handleFlowControls` if the suppress flag is set.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The change was done as proposed by the analysis
+* Revision: [r400]
+* Implementation test: Tests were performed with and without semicolons in loops. The expressions were numerical and string expressions

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: The changed sections were commented
+* Documentation articles: Not needed - intended behavior
+* Language files: Not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r400]

  • Erik Hänel

    Erik Hänel - 2018-11-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This change was tested thoroughly in production and durability tests. All deviations were fixed.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB