Menu ▾ ▴

#376 Closing the application cannot be vetoed

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.0
Bug Fix
2018-11-14
2018-09-12
Erik Hänel
No

If there's a editor file, which was not saved and the user clicks on cancel during closing the app, NumeRe won't stop the closing process.

Analysis:

The issue is that the NumeReWindow::CloseAllFiles() is a void function instead of a boolean. Therefore the return value of NumeReWindow::HandleModifiedFile() cannot be used to abort the overall process. Change the return value and return false if the user clicks on cancel.

Implementation:

  • Implementation: The fix was implemented as proposed by the analysis.
  • Revision: [r393]
  • Implementation test: A file was modified and NumeRe should close. After clicking on cancel, the process stopped and the file could be modified further.

Documentation:

  • ChangesLog: updated
  • Comments: Too small change
  • Documentation articles: Not needed - bug fix
  • Language files: Not needed - bug fix

Tests:

This fix was tested manually. No deviations occured.

Related

Commit: [r393]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-09-12
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-09-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 If there's a editor file, which was not saved and the user clicks on cancel during closing the app, NumeRe won't stop the closing process.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-09-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 If there's a editor file, which was not saved and the user clicks on cancel during closing the app, NumeRe won't stop the closing process.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The issue is that the `NumeReWindow::CloseAllFiles()` is a `void` function instead of a `boolean`. Therefore the return value of `NumeReWindow::HandleModifiedFile()` cannot be used to abort the overall process. Change the return value and return `false` if the user clicks on cancel.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-09-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 The issue is that the `NumeReWindow::CloseAllFiles()` is a `void` function instead of a `boolean`. Therefore the return value of `NumeReWindow::HandleModifiedFile()` cannot be used to abort the overall process. Change the return value and return `false` if the user clicks on cancel.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was implemented as proposed by the analysis.
+* Revision: [r393]
+* Implementation test: A file was modified and NumeRe should close. After clicking on cancel, the process stopped and the file could be modified further.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: Too small change
+* Documentation articles: Not needed - bug fix
+* Language files: Not needed - bug fix

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r393]

  • Erik Hänel

    Erik Hänel - 2018-11-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed - bug fix

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested manually. No deviations occured.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB