Menu ▾ ▴

#364 Issue in reworked resampler code

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.1
Bug Fix
2018-11-10
2018-08-08
Erik Hänel
No

The resampler algorithm does not work as expected. In contrast to resmpling the selected area, it always only resamples the columns in front of the last column.

Analysis:

The issue is that the indices are not evaluated correctly inside. This is an known issue, which is caused by a not cleanly defined interface between the memory functions and the calculated indices. Change the overall behavior so that the memory functions always expect direct indices (i.e. the last index points to the last element and not to the one before).

Implementation:

  • Implementation: The fix was done as proposed by the analysis.
  • Revision: [r372]
  • Implementation test: A software test was carried out to ensure compatibility.

Documentation:

  • ChangesLog: updated
  • Comments: The changed functions in memory.cpp are commented sufficiently
  • Documentation articles: Not needed - Bug fix
  • Language files: Not needed - Bug fix

Tests:

This fix was tested thoroughly in production tests. All deviations were resolved.

Related

Commit: [r372]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-08-08
    • labels: --> critical
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-08-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 The resampler algorithm does not work as expected. In contrast to resmpling the selected area, it always only resamples the columns in front of the last column.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was succesful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-08-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The resampler algorithm does not work as expected. In contrast to resmpling the selected area, it always only resamples the columns in front of the last column.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The issue is that the indices are not evaluated correctly inside. This is an known issue, which is caused by a not cleanly defined interface between the memory functions and the calculated indices. Change the overall behavior so that the memory functions always expect direct indices (i.e. the last index points to the last element and not to the one before).

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-08-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 The issue is that the indices are not evaluated correctly inside. This is an known issue, which is caused by a not cleanly defined interface between the memory functions and the calculated indices. Change the overall behavior so that the memory functions always expect direct indices (i.e. the last index points to the last element and not to the one before).

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was succesful*)
+* Implementation: The fix was done as proposed by the analysis.
+* Revision: [r372]
+* Implementation test: A software test was carried out to ensure compatibility.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: The changed functions in `memory.cpp` are commented sufficiently
+* Documentation articles: Not needed - Bug fix
+* Language files: Not needed - Bug fix

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r372]

  • Erik Hänel

    Erik Hänel - 2018-11-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed - Bug fix

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested thoroughly in production tests. All deviations were resolved.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB