Menu ▾ ▴

#362 Issues with source-code like string contents

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.0
Bug Fix
2018-11-16
2018-08-07
Erik Hänel
No

If one uses lines like the following in strings

"abnahmesettings = [{messablauf.Pupillenmessung.Setting.Name}, {messablauf.Feldmessung.Setting.Name}];"
"nr_setting = eos.utils.Get_setting_names(abnahmesettings{s}, 'number');"

and uses them as a return value of a procedure, the return value is converted in some strange number.

Analysis:

There are two issues:

  • The strange number occurs probably because the parser throws an error returning the last parsed expression instead of the currently parsed one
  • The legacy function parser_vectorToExpr(), which is only used by the string parser, doesn't match the vector braces correctly

Implementation:

  • Implementation: The two issues of the analysis were fixed correspondingly
  • Revision: [r376]
  • Implementation test: The mentioned strings were used as return values of procedures and were passed successfully.

Documentation:

  • ChangesLog: updated
  • Comments: The changed functions were commented sufficiently.
  • Documentation articles: Not needed - bug fix
  • Language files: Not needed - bug fix

Tests:

This fix was added to the automatic SW tests. No deviations detected.

Related

Commit: [r376]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-08-08
    • labels: --> critical
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-08-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,3 +4,20 @@
     "nr_setting = eos.utils.Get_setting_names(abnahmesettings{s}, 'number');"

 and uses them as a return value of a procedure, the return value is converted in some strange number.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was succesful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-08-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -6,7 +6,10 @@
 and uses them as a return value of a procedure, the return value is converted in some strange number.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+There are two issues:
+
+* The strange number occurs probably because the parser throws an error returning the last parsed expression instead of the currently parsed one
+* The legacy function `parser_vectorToExpr()`, which is only used by the string parser, doesn't match the vector braces correctly

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-08-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -12,15 +12,15 @@

 * The legacy function `parser_vectorToExpr()`, which is only used by the string parser, doesn't match the vector braces correctly

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was succesful*)
+* Implementation: The two issues of the analysis were fixed correspondingly
+* Revision: [r376]
+* Implementation test: The mentioned strings were used as return values of procedures and were passed successfully.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: The changed functions were commented sufficiently.
+* Documentation articles: Not needed - bug fix
+* Language files: Not needed - bug fix

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r376]

  • Erik Hänel

    Erik Hänel - 2018-11-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -23,4 +23,4 @@

 * Language files: Not needed - bug fix

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was added to the automatic SW tests. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB