Menu ▾ ▴

#342 'datagrid' has issues with non-symmetric data sets

v1.1.x
fixed
Erik Hänel
None
v1.1.1
Bug Fix
2018-11-16
2018-06-04
Erik Hänel
No

The command datagrid is probably not able to handle non-symmetric data sets as a base for a datagrid.

Analysis:
The issue is that the samples are only calculated for a reasonable but not for the correct direction. This means that the numbers of the first non-singleton direction are used globally for both directions.

Implementation:
The fix was implemented as proposed by the analysis. Additionally, the whole datagrid function was split up into multiple subfunctions to reduce the overall complexity of the function. Implementation tests were passed successfully.

Documentation:
The fix was added to the changes log. Comments were added to the code. Further documentation not needed.

Tests:
This fix was added to the automatic SW tests. No deviations detected.

Discussion

  • Erik Hänel

    Erik Hänel - 2018-06-10
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-07-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 The command `datagrid` is probably not able to handle non-symmetric data sets as a base for a datagrid.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-07-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 The command `datagrid` is probably not able to handle non-symmetric data sets as a base for a datagrid.

 **Analysis:**
+The issue is that the samples are only calculated for a reasonable but not for the correct direction. This means that the numbers of the first non-singleton direction are used globally for both directions.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-07-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,9 @@
 The issue is that the samples are only calculated for a reasonable but not for the correct direction. This means that the numbers of the first non-singleton direction are used globally for both directions.

 **Implementation:**
+The fix was implemented as proposed by the analysis. Additionally, the whole `datagrid` function was split up into multiple subfunctions to reduce the overall complexity of the function. Implementation tests were passed successfully.

 **Documentation:**
+The fix was added to the changes log. Comments were added to the code. Further documentation not needed.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2018-11-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,4 @@
 The fix was added to the changes log. Comments were added to the code. Further documentation not needed.

 **Tests:**
+This fix was added to the automatic SW tests. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB