Menu ▾ ▴

#332 The "floor()" function is not working on data sets

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.0
Bug Fix
2018-05-23
2018-05-18
Erik Hänel
No

The floor() function cannot be applied on data sets. It will always return zeros.

Analysis:
This issue comes from a very lazy function detection in the data access: floor() is recognized as or() and will be replaced accordingly, so that a new variable floor[dataset] is created, which doesn't even contain the results from or(DATASET).

Create a token reader, which will return the last token left to the data set, to solve this issue.

Implementation:
The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

Documentation:
The fix was noted in the changes log. Further documentation not necessary.

Tests:
The fix was added to the automatic tests. No deviation detected. Bug fix implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2018-05-18
    • summary: The "floor()" functionis not working on data sets --> The "floor()" function is not working on data sets
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-05-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 The `floor()` function cannot be applied on data sets. It will always return zeros.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-05-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,9 @@
 The `floor()` function cannot be applied on data sets. It will always return zeros.

 **Analysis:**
+This issue comes from a very lazy function detection in the data access: `floor()` is recognized as `or()` and will be replaced accordingly, so that a new variable `floor[dataset]` is created, which doesn't even contain the results from `or(DATASET)`.
+
+Create a token reader, which will return the last token left to the data set, to solve this issue.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-05-19
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2018-05-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -6,7 +6,9 @@
 Create a token reader, which will return the last token left to the data set, to solve this issue.

 **Implementation:**
+The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

 **Documentation:**
+The fix was noted in the changes log. Further documentation not necessary.

 **Tests:**
     

  • Erik Hänel

    Erik Hänel - 2018-05-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -12,3 +12,4 @@
 The fix was noted in the changes log. Further documentation not necessary.

 **Tests:**
+The fix was added to the automatic tests. No deviation detected. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB