Menu

#325 String variables cannot be used as plotting legends

v1.1.x
fixed
critical (96)
v1.1.0
Bug Fix
2018-05-15
2018-05-04
Erik Hänel
No

Something like

plot _extWifi(:, 1:2) sLegend1, _extWifi(:, 3:4) sLegend2, _extWifi(:, 5:6) sLegend3

is currently not possible.

Analysis:
The string variables are not read before the call to addLegends(). Add the following lines

if (_data.containsStringVars(sFunc))
            _data.getStringValues(sFunc);

before the call to addLegends().

Implementation:
The implementation was done as proposed by the analysis. Implementation tests were passed successfully.

Documentation:
The fox was noted in the changes log. Further documentation not needed.

Tests:
The fix was tested in productive environment. No deviations detected. Bug fix implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2018-05-04
    • status: open --> accepted
     
  • Erik Hänel

    Erik Hänel - 2018-05-04
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -3,3 +3,11 @@
         plot _extWifi(:, 1:2) sLegend1, _extWifi(:, 3:4) sLegend2, _extWifi(:, 5:6) sLegend3
    
     is currently not possible.
    +
    +**Analysis:**
    +
    +**Implementation:**
    +
    +**Documentation:**
    +
    +**Tests:**
    
    • status: accepted --> analyzing
     
  • Erik Hänel

    Erik Hänel - 2018-05-04
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -5,6 +5,13 @@
     is currently not possible.
    
     **Analysis:**
    +The string variables are not read before the call to `addLegends()`. Add the following lines
    +
    
    +    :::C++
    +    if (_data.containsStringVars(sFunc))
    +                _data.getStringValues(sFunc);
    +
    +before the call to `addLegends()`.
    
     **Implementation:**
    
    • status: analyzing --> implementing
     
  • Erik Hänel

    Erik Hänel - 2018-05-04
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -14,7 +14,9 @@
     before the call to `addLegends()`.
    
     **Implementation:**
    +The implementation was done as proposed by the analysis. Implementation tests were passed successfully.
    
     **Documentation:**
    +The fox was noted in the changes log. Further documentation not needed.
    
     **Tests:**
    
    • status: implementing --> testing
     
  • Erik Hänel

    Erik Hänel - 2018-05-15
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -20,3 +20,4 @@
     The fox was noted in the changes log. Further documentation not needed.
    
     **Tests:**
    +The fix was tested in productive environment. No deviations detected. Bug fix implemented successfully.
    
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB