Menu ▾ ▴

#300 NumeRe crashes if 'getfolderlist("*")' is used

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.1
Bug Fix
2018-04-25
2018-03-31
Erik Hänel
No

NumeRe crashes, if one uses getfolderlist("*") or getfilelist("*") in the console.

Analysis:
NumeRe crashes because it tries to use more memory than exists. The reason for this behavior is the recursion for path tokens in getfolderlist() and getfilelist() doesn't abort, if the passed string doesn't contain any path separators.

Implementation:
The recursion now aborts if no path separator can be found in the passed string.

Documentation:
The fix was documented in the changes log.

Tests:
The fix was tested and no deviations were detected. Bug fix implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2018-03-31
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-03-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 NumeRe crashes, if one uses `getfolderlist("*")` or `getfilelist("*")` in the console.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-03-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 NumeRe crashes, if one uses `getfolderlist("*")` or `getfilelist("*")` in the console.

 **Analysis:**
+NumeRe crashes because it tries to use more memory than exists. The reason for this behavior is the recursion for path tokens in `getfolderlist()` and `getfilelist()` doesn't abort, if the passed string doesn't contain any path separators.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-03-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,9 @@
 NumeRe crashes because it tries to use more memory than exists. The reason for this behavior is the recursion for path tokens in `getfolderlist()` and `getfilelist()` doesn't abort, if the passed string doesn't contain any path separators.

 **Implementation:**
+The recursion now aborts if no path separator can be found in the passed string.

 **Documentation:**
+The fix was documented in the changes log.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2018-04-25
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,4 @@
 The fix was documented in the changes log.

 **Tests:**
+The fix was tested and no deviations were detected. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB