Menu ▾ ▴

#288 Refactor parser_functions.cpp

v1.1.x
closed
Erik Hänel
None
v1.1.2
Change Request
2019-12-10
2018-03-07
Erik Hänel
No

The file kernel/core/maths/parser_functions.cpp is filled with more or less legacy code. Refactor this file to comply with the more elaborate implementation of kernel/core/stringparsing.cpp or kernel/core/plotting/plotting.cpp.

Analysis:

  • [x] Separate the functions in multiple files
  • [x] Reduce the number of code duplicates
  • [x] Remove unneeded functions

Implementation:

  • Implementation: The changes were processed as listed in the analysis.
  • Revision: [r669]
  • Implementation test: A complete SW test was run and all deviations were fixed.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

This change was tested by running a complete SW test. No deviations detected.

Related

Commit: [r669]

Discussion

  • Erik Hänel

    Erik Hänel - 2018-03-07
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-11-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The file `kernel/core/maths/parser_functions.cpp` is filled with more or less legacy code. Refactor this file to comply with the more elaborate implementation of `kernel/core/stringparsing.cpp` or `kernel/core/plotting/plotting.cpp`.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
    • Version: Planned --> v1.1.2
     

  • Erik Hänel

    Erik Hänel - 2019-11-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,9 @@
 The file `kernel/core/maths/parser_functions.cpp` is filled with more or less legacy code. Refactor this file to comply with the more elaborate implementation of `kernel/core/stringparsing.cpp` or `kernel/core/plotting/plotting.cpp`.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+* [ ] Separate the functions in multiple files
+* [ ] Reduce the number of code duplicates
+* [ ] Remove unneeded functions

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-12-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,25 +1,25 @@
 The file `kernel/core/maths/parser_functions.cpp` is filled with more or less legacy code. Refactor this file to comply with the more elaborate implementation of `kernel/core/stringparsing.cpp` or `kernel/core/plotting/plotting.cpp`.

 ###Analysis:
-* [ ] Separate the functions in multiple files
-* [ ] Reduce the number of code duplicates
-* [ ] Remove unneeded functions
+* [x] Separate the functions in multiple files
+* [x] Reduce the number of code duplicates
+* [x] Remove unneeded functions

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The changes were processed as listed in the analysis.
+* Revision: [r669]
+* Implementation test: A complete SW test was run and all deviations were fixed.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r669]

  • Erik Hänel

    Erik Hänel - 2019-12-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -22,4 +22,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This change was tested by running a complete SW test. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB