Menu ▾ ▴

#280 "export" doesn't work on tables

v1.1.x
fixed
Erik Hänel
None
v1.1.0
Bug Fix
2018-03-01
2018-01-30
Erik Hänel
No

The export command doesn't work on tables. Instead it opens the table for viewing it in the table viewer.

Analysis:
The issue is a missing check for the save flag. Instead of

if (_option.getUseExternalViewer())
    NumeReKernel::showTable(sOut, nCol, nLine, sCache);

It should be

if (_option.getUseExternalViewer() && !bSave)
    NumeReKernel::showTable(sOut, nCol, nLine, sCache);

Implementation:
The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

Documentation:
Not needed - Bug fix.

Tests:
The fix was added to the automatic tests. No deviations detected. Bug fix implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2018-01-30
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-01-30
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 The `export` command doesn't work on tables. Instead it opens the table for viewing it in the table viewer.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-01-30
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,17 @@
 The `export` command doesn't work on tables. Instead it opens the table for viewing it in the table viewer.

 **Analysis:**
+The issue is a missing check for the save flag. Instead of
+

+    :::C++
+    if (_option.getUseExternalViewer())
+        NumeReKernel::showTable(sOut, nCol, nLine, sCache);
+            
+It should be
+
+    :::C++
+    if (_option.getUseExternalViewer() && !bSave)
+        NumeReKernel::showTable(sOut, nCol, nLine, sCache);

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-01-30
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -14,7 +14,9 @@
         NumeReKernel::showTable(sOut, nCol, nLine, sCache);

 **Implementation:**
+The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

 **Documentation:**
+Not needed - Bug fix.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2018-03-01
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,3 +20,4 @@
 Not needed - Bug fix.

 **Tests:**
+The fix was added to the automatic tests. No deviations detected. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB