Menu ▾ ▴

#271 Sorting a table with many NaNs is sometimes unsuccessful

v1.1.x
fixed
Erik Hänel
None
v1.1.0
Bug Fix
2018-03-05
2018-01-19
Erik Hänel
No

Tables containing many NaNs are in some cases not sorted completely or unsuccessful.

Analysis:
The comparsison with NaNs in the qSort algorithm seem to have issues and cannot be successful with many NaNs. Manually moving the NaNs to the end might solve this issue.

Implementation:
The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

Documentation:
Not needed - Bug fix.

Tests:
The fix was added to the automatic tests. No deviation detected. Bug fix implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2018-01-19
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2018-01-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 Tables containing many NaNs are in some cases not sorted completely or unsuccessful.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2018-01-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 Tables containing many NaNs are in some cases not sorted completely or unsuccessful.

 **Analysis:**
+The comparsison with NaNs in the `qSort` algorithm seem to have issues and cannot be successful with many NaNs. Manually moving the NaNs to the end might solve this issue.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2018-01-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,9 @@
 The comparsison with NaNs in the `qSort` algorithm seem to have issues and cannot be successful with many NaNs. Manually moving the NaNs to the end might solve this issue.

 **Implementation:**
+The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

 **Documentation:**
+Not needed - Bug fix.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2018-03-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,4 @@
 Not needed - Bug fix.

 **Tests:**
+The fix was added to the automatic tests. No deviation detected. Bug fix implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB