Menu ▾ ▴

#254 variables beginning with "for..." inside of loops are misinterpreted as "for ()"

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.0
Bug Fix
2017-12-12
2017-11-04
Erik Hänel
No

If one uses variables or caches inside of loops or forks that begin with "for...", then NumeRe interpretes them as new "for ()" and asks for the loop definition. One cannot leave this situation and has to kill the whole application.

Analysis:
The solution is simple: just use the findCommand() function to extract the command in Loop::setCommand() and check against this command.

Implementation:
The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

Documentation:
Not needed - Bug fix.

Tests:
Software test returned no deviations. Fix was implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2017-11-04
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2017-11-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 If one uses variables or caches inside of loops or forks that begin with "for...", then NumeRe interpretes them as new "for ()" and asks for the loop definition. One cannot leave this situation and has to kill the whole application.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2017-11-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 If one uses variables or caches inside of loops or forks that begin with "for...", then NumeRe interpretes them as new "for ()" and asks for the loop definition. One cannot leave this situation and has to kill the whole application.

 **Analysis:**
+The solution is simple: just use the `findCommand()` function to extract the command in `Loop::setCommand()` and check against this command.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2017-11-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,9 @@
 The solution is simple: just use the `findCommand()` function to extract the command in `Loop::setCommand()` and check against this command.

 **Implementation:**
+The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

 **Documentation:**
+Not needed - Bug fix.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2017-12-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,4 @@
 Not needed - Bug fix.

 **Tests:**
+Software test returned no deviations. Fix was implemented successfully.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB