Menu ▾ ▴

#224 Avoid duplicates in the entry history

v1.1.x
closed
Erik Hänel
None
v1.1.0
Change Request
2017-08-19
2017-07-12
Erik Hänel
No

If one enters the same line repeatedly, it's not helpful, if this line is stored repeatedly in the history: add a check, if the last line is identical to the current line and only add the current line, if this is not the case. (Do the comparsion not whitespace-sensitive)

Analysis:
This change can be implemented in the member function NumeReHistory::AddToHistory(), where the recent line has to be read and compared to the new line and only added if they are different.

Implementation:
The change was implemented as proposed by the analysis. Implementation tests were passed successfully.

Documentation:
A description of the changed behavior was added to the documentation articles concerning the entry history in both languages.

Tests:
Duplicates are not showing up any more. Change was implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2017-07-12
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2017-07-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 If one enters the same line repeatedly, it's not helpful, if this line is stored repeatedly in the history: add a check, if the last line is identical to the current line and only add the current line, if this is not the case. (Do the comparsion not whitespace-sensitive)
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2017-07-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 If one enters the same line repeatedly, it's not helpful, if this line is stored repeatedly in the history: add a check, if the last line is identical to the current line and only add the current line, if this is not the case. (Do the comparsion not whitespace-sensitive)

 **Analysis:**
+This change can be implemented in the member function `NumeReHistory::AddToHistory()`, where the recent line has to be read and compared to the new line and only added if they are different.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2017-07-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,9 @@
 This change can be implemented in the member function `NumeReHistory::AddToHistory()`, where the recent line has to be read and compared to the new line and only added if they are different.

 **Implementation:**
+The change was implemented as proposed by the analysis. Implementation tests were passed successfully.

 **Documentation:**
+A description of the changed behavior was added to the documentation articles concerning the entry history in both languages.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2017-08-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,4 @@
 A description of the changed behavior was added to the documentation articles concerning the entry history in both languages.

 **Tests:**
+Duplicates are not showing up any more. Change was implemented successfully.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB