Menu ▾ ▴

#164 The autofocusing of UI elements is unsuitable for search & replace

v1.1.x
closed
Erik Hänel
None
v1.1.0
Change Request
2017-05-04
2017-03-02
Erik Hänel
No

If one uses a search & replace dialog it's distracting and unsuitable, if the focus moves from the dialog when the mouse moves.

Analysis:
One contribution is the deactivation of moving the focus after a match was found. This can be done in the function NumeReWindow::OnFindEvent(). The other possibilities have to be investigated as there's no simple way of accessing the top level window without creating a loop in the include macros. A possible solution would be a global pointer to the find & replace dialog.

Implementation:
The search & replace dialog was moved to a global instance governed by the NumeReWindow toplevel class. The different OnEnter handlers of the main GUI are now aware of the open dialog and ignore their behavior in this case.

Documentation:
Not needed - Improving of already available behavior.

Tests:
The focus now works as expected. No deviations detected. Change was implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2017-03-02
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2017-03-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 If one uses a search & replace dialog it's distracting and unsuitable, if the focus moves from the dialog when the mouse moves.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2017-03-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 If one uses a search & replace dialog it's distracting and unsuitable, if the focus moves from the dialog when the mouse moves.

 **Analysis:**
+One contribution is the deactivation of moving the focus after a match was found. This can be done in the function `NumeReWindow::OnFindEvent()`. The other possibilities have to be investigated as there's no simple way of accessing the top level window without creating a loop in the include macros. A possible solution would be a global pointer to the find & replace dialog.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2017-03-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,9 @@
 One contribution is the deactivation of moving the focus after a match was found. This can be done in the function `NumeReWindow::OnFindEvent()`. The other possibilities have to be investigated as there's no simple way of accessing the top level window without creating a loop in the include macros. A possible solution would be a global pointer to the find & replace dialog.

 **Implementation:**
+The search & replace dialog was moved to a global instance governed by the NumeReWindow toplevel class. The different OnEnter handlers of the main GUI are now aware of the open dialog and ignore their behavior in this case.

 **Documentation:**
+Not needed - Improving of already available behavior.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2017-05-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,4 @@
 Not needed - Improving of already available behavior.

 **Tests:**
+The focus now works as expected. No deviations detected. Change was implemented successfully.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB