Menu ▾ ▴

#141 string-wstring error in editor

v1.1.x
fixed
Erik Hänel
None
v1.1.0
Bug Fix
2017-02-14
2017-02-01
Erik Hänel
No

Obviously is there a issue concerning the string-wstring interaction in the editor, because marking a word with an umlaut in it won't mark the whole word. Probably a converting error occures at this point.

Analysis:
A probable issue is the usage of the wxString::length() function, which counts the bytes not the glyphs. This can be solved by using the start and end points in the highlighting functions rather than the length() function. This guess was verified.

Implementation:
Fix was implemented as proposed by the analysis.

Documentation:
Not needed - bug fix.

Tests:
Bug fix was verified in a durability test. Bug fix accepted.

Discussion

  • Erik Hänel

    Erik Hänel - 2017-02-01
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2017-02-01
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 Obviously is there a issue concerning the string-wstring interaction in the editor, because marking a word with an umlaut in it won't mark the whole word. Probably a converting error occures at this point.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2017-02-01
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 Obviously is there a issue concerning the string-wstring interaction in the editor, because marking a word with an umlaut in it won't mark the whole word. Probably a converting error occures at this point.

 **Analysis:**
+A probable issue is the usage of the `wxString::length()` function, which counts the bytes not the glyphs. This can be solved by using the start and end points in the highlighting functions rather than the `length()` function.

 **Implementation:**
     

  • Erik Hänel

    Erik Hänel - 2017-02-01
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Obviously is there a issue concerning the string-wstring interaction in the editor, because marking a word with an umlaut in it won't mark the whole word. Probably a converting error occures at this point.

 **Analysis:**
-A probable issue is the usage of the `wxString::length()` function, which counts the bytes not the glyphs. This can be solved by using the start and end points in the highlighting functions rather than the `length()` function.
+A probable issue is the usage of the `wxString::length()` function, which counts the bytes not the glyphs. This can be solved by using the start and end points in the highlighting functions rather than the `length()` function. This guess was verified.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2017-02-01
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,9 @@
 A probable issue is the usage of the `wxString::length()` function, which counts the bytes not the glyphs. This can be solved by using the start and end points in the highlighting functions rather than the `length()` function. This guess was verified.

 **Implementation:**
+Fix was implemented as proposed by the analysis.

 **Documentation:**
+Not needed - bug fix.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2017-02-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,4 @@
 Not needed - bug fix.

 **Tests:**
+Bug fix was verified in a durability test. Bug fix accepted.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB