Menu ▾ ▴

#125 Add GUI breakpoint functionality

v1.1.x
closed
Erik Hänel
None
v1.1.0
New Functionality
2017-02-15
2017-01-22
Erik Hänel
No

Currently only the text based breakpoints are interpreted. The breakpoints, which were set by the GUI function, aren't used. Add this functionality, e.g. by a new class, which monitors the marked lines in the opened files and signals the kernel functions where to add a breakpoint symbol during reading the file.

Analysis:
The main data set of this new class should be a std::map<std::string,std::vector>, where the string names the actual file and the vector contains the line numbers of the desired breakpoints. The communication should be thread-aware. There are two main possibilities: either there are two instances of the new class communicating thread-safe or there's only one instance in the second thread with a thread-safe interface. For the performance it would be better, if there are two instances of the class, because in this case the inter-thread communication can be held in the lowest amount possible. This requires a clean copy constructor-like interface.

Implementation:
A class with two instances was implemented as proposed by the analysis. It is now possible to create temporary breakpoints (they invalidate, if the file or NumeRe is closed), which will internally used as usual breakpoints.

Documentation:
Not needed: Breakpoints are already documented and the GUI functions describe themselves.

Tests:
Multiple tests were passed without any deviation. Functionality working as expected.

Discussion

  • Erik Hänel

    Erik Hänel - 2017-01-22
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2017-01-22
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 Currently only the text based breakpoints are interpreted. The breakpoints, which were set by the GUI function, aren't used. Add this functionality, e.g. by a new class, which monitors the marked lines in the opened files and signals the kernel functions where to add a breakpoint symbol during reading the file. 
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2017-01-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 Currently only the text based breakpoints are interpreted. The breakpoints, which were set by the GUI function, aren't used. Add this functionality, e.g. by a new class, which monitors the marked lines in the opened files and signals the kernel functions where to add a breakpoint symbol during reading the file. 

 **Analysis:**
+The main data set of this new class should be a `std::map<std::string,std::vector>`, where the `string` names the actual file and the `vector` contains the line numbers of the desired breakpoints. The communication should be thread-aware. There are two main possibilities: either there are two instances of the new class communicating thread-safe or there's only one instance in the second thread with a thread-safe interface. For the performance it would be better, if there are two instances of the class, because in this case the inter-thread communication can be held in the lowest amount possible. This requires a clean copy constructor-like interface.

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2017-01-24
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,7 +4,9 @@
 The main data set of this new class should be a `std::map<std::string,std::vector>`, where the `string` names the actual file and the `vector` contains the line numbers of the desired breakpoints. The communication should be thread-aware. There are two main possibilities: either there are two instances of the new class communicating thread-safe or there's only one instance in the second thread with a thread-safe interface. For the performance it would be better, if there are two instances of the class, because in this case the inter-thread communication can be held in the lowest amount possible. This requires a clean copy constructor-like interface.

 **Implementation:**
+A class with two instances was implemented as proposed by the analysis. It is now possible to create temporary breakpoints (they invalidate, if the file or NumeRe is closed), which will internally used as usual breakpoints.

 **Documentation:**
+Not needed: Breakpoints are already documented and the GUI functions describe themselves.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2017-02-15
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,4 @@
 Not needed: Breakpoints are already documented and the GUI functions describe themselves.

 **Tests:**
+Multiple tests were passed without any deviation. Functionality working as expected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB