Menu ▾ ▴

#102 "open" doesn't work with "<procpath>"

v1.0.x
fixed
Erik Hänel
critical (96)
v1.0.9
Bug Fix
2016-10-08
2016-09-04
Erik Hänel
No

The command open <procpath> doesn't work, although it works with every other path placeholder.

Analysis:
The error is located in 

string FileSystem::ValidFileName(string, const string)

where the number of path tokens is not set correctly (it's set to 6 instead of 7).

Implementation:
The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

Documentation:
Not needed - bug fix.

Tests:
Command now works as expected. Bug fix implemented successfully.

Discussion

  • Erik Hänel

    Erik Hänel - 2016-09-05
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2016-09-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,9 @@
 The command `open <procpath>` doesn't work, although it works with every other path placeholder.
+
+**Analysis:**
+
+**Implementation:**
+
+**Documentation:**
+
+**Tests:**
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2016-09-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,11 @@
 The command `open <procpath>` doesn't work, although it works with every other path placeholder.

 **Analysis:**
+The error is located in 
+~~~C
+string FileSystem::ValidFileName(string, const string)
+~~~
+where the number of path tokens is not set correctly (it's set to 6 instead of 7).

 **Implementation:**
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2016-09-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -8,7 +8,9 @@
 where the number of path tokens is not set correctly (it's set to 6 instead of 7).

 **Implementation:**
+The fix was implemented as proposed by the analysis. Implementation tests were passed successfully.

 **Documentation:**
+Not needed - bug fix.

 **Tests:**
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2016-09-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -14,3 +14,4 @@
 Not needed - bug fix.

 **Tests:**
+Command now works as expected. Bug fix implemented successfully.
    • status: testing --> fixed
     

  • Erik Hänel

    Erik Hänel - 2016-10-08
    • Labels: --> critical
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB