number-format-developers Mailing List for Number::Format (Page 2)
Brought to you by:
billward
You can subscribe to this list here.
2006 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(39) |
Oct
(9) |
Nov
|
Dec
|
---|---|---|---|---|---|---|---|---|---|---|---|---|
2008 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(1) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
From: Jonas B. N. <jo...@gm...> - 2006-09-21 19:03:47
|
Hello, See below, On 21/09/2006, at 20.45, Bill Ward wrote: > I have decided to release 1.52 with that \s+ to \s* change now, and > then we can concentrate on other features. > Sounds good, I will skip the related tests then... > I have updated all the files such as README and CHANGES for the > release and am checking those in now, then I will be applying the CVS > label. Please don't make any more commits until I give the word. > Perhaps we should have a branching strategy? so we can work on issues in parallel or we create a subproject aiming at a release - I think this is normally called a roadmap :) > I also took the 3 issues listed in the TODO file and entered them in > the Feature Requests tracker. You should all be able to access the > tracker now: > http://sourceforge.net/tracker/?group_id=175334&atid=872819 > I think we should enter the bugs from RT under the Bugs or Support > Requests trackers, not the Tasks list. Any thoughts on that? I'm new > at this SourceForge admin stuff so if you think I should do it > differently please speak up. Also don't hesitate to ask for access to > something that you may be blocked from doing currently. > Well it is all things which needs to be done, the task listing would enable us to plan when the bugs should be fixed and we keep them in RT until resolved. Otherwise we should mention that bug reports should go to sf.net instead of rt.cpan.org. > -- > Help bring back the San Jose Earthquakes - http:// > www.soccersiliconvalley.com/ > > ---------------------------------------------------------------------- > --- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to > share your > opinions on IT & business topics through brief surveys -- and earn > cash > http://www.techsay.com/default.php? > page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Number-Format-Developers mailing list > Num...@li... > https://lists.sourceforge.net/lists/listinfo/number-format-developers Just my 5 cents, jonasbn |
From: Bill W. <bi...@wa...> - 2006-09-21 18:45:54
|
I have decided to release 1.52 with that \s+ to \s* change now, and then we can concentrate on other features. I have updated all the files such as README and CHANGES for the release and am checking those in now, then I will be applying the CVS label. Please don't make any more commits until I give the word. I also took the 3 issues listed in the TODO file and entered them in the Feature Requests tracker. You should all be able to access the tracker now: http://sourceforge.net/tracker/?group_id=175334&atid=872819 I think we should enter the bugs from RT under the Bugs or Support Requests trackers, not the Tasks list. Any thoughts on that? I'm new at this SourceForge admin stuff so if you think I should do it differently please speak up. Also don't hesitate to ask for access to something that you may be blocked from doing currently. -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Cees H. <ce...@gm...> - 2006-09-20 16:30:42
|
On 9/19/06, Bill Ward <bi...@wa...> wrote: > I just realized - we already have a line that says "require 5.008" so > nevermind all this business about backward compatibility. Let the > Test::More changes be commited. Hi All, Just jumping into the middle of this discussion. I am pretty sure that Test::More runs fine on older architectures, it is just not installed by default. Also, you would be hard-pressed to find a distribution on CPAN (at least from the list of quality/well maintained modules) that do not use Test::More. I would think that it is a reasonable requirement to add. One thing to keep in mind is that a test suite is only good if it is bug free. Using a tried and tested module like Test::More could reduce the likelyhood of errors creaping into the test suite. Cheers, Cees ps for those of you wondering why I am on this list, I wrote the JavaScript port of Number::Format. If anyone is interested in helping me out with that, let me know (it is in CVS on sourceforge already). My aim is to keep it as a 100% clone of the per version. |
From: Bill W. <bi...@wa...> - 2006-09-19 22:19:12
|
Now that I think about it - I am pretty sure that when I did 1.51 I had several locale related bugs to fix, and I fixed them and decided not to try to support older versions of Perl. From the Format.pm code, it says: # Due to differences in the locale system Perl 5.8 is required for # this module to function properly. You may be able to get it to work # on older Perls by uncommenting this line, but it is not supported. # I recommend you either upgrade Perl or download an older version of # this module in that case. require 5.008; That said, if someone wants to make the effort to ensure compatibility with older versions, that's fine with me... On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > Well, > > Shouldn't we aim for backwards compability to the extent possible or > can you say now that handling locales are not worth the effort prior > to 5.8? > > jonasbn > |
From: Bill W. <bi...@wa...> - 2006-09-19 22:07:56
|
As I upload the old releases to the SourceForge download area, I am discovering that the CVS versions do *not* match up with the release versions after all. It tricked me because the CVS version was 1.42 and the release was 1.52. There's a tag in CVS called release-x-yy for version x.yy (but I notice this tag isn't set for the latest couple of versions!) which correlates the releases to the CVS versions. Sorry for the stupidity, but I'm new at SourceForge and I've ignored this pacakge so long I forgot how I was doing it!! On 9/19/06, Bill Ward <bi...@wa...> wrote: > I just realized - we already have a line that says "require 5.008" so > nevermind all this business about backward compatibility. Let the > Test::More changes be commited. > > On 9/19/06, Bill Ward <bi...@wa...> wrote: > > OK. I thought I had granted you the necessary access to administer > > the tasks system. Let me look into it. > > > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > > > Hi Bill, > > > > > > If that is the case, I say we wait a few days and try to eliminate as > > > many as the reported issues as possible. > > > > > > I still cannot create tasks on sf.net, or perhaps I just do not > > > understand how to, but else we could just go over the list I wroteup. > > > > > > As far as I can tell we are already two requests down :-) > > > > > > jonasbn > > > > > > On 19/09/2006, at 22.56, Bill Ward wrote: > > > > > > > Not sure how we would roll it back without access to the CVS > > > > repository itself...? > > > > Never mind ... let's just go to 1.6 as the next release. Are there > > > > any other low-hanging fruit type changes that anyone wants to make for > > > > this? > > > > > > > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > > > >> Hi Bill, > > > >> > > > >> Well you do not have to use the revision number, I just expected you > > > >> auto-incremented the version number based on the revision number, I > > > >> can see now that this is not the case, we might as well call this > > > >> release 1.52 or we could roll back to 1.51 and try again? > > > >> > > > >> I will look into writing a test for the patch. > > > >> > > > >> jonasbn > > > >> > > > >> On 19/09/2006, at 22.46, Bill Ward wrote: > > > >> > > > >> > Damnit, the version number! I thought it was automatically > > > >> converted > > > >> > from the CVS version but I see that it is hard coded. So I guess > > > >> > version 1.52 now has to include CVS version 1.53. Ugh. > > > >> > > > > >> > As for the test, I like to follow the policy that any change made > > > >> > should have a test explicitly designed to cover that change. In > > > >> this > > > >> > case we could test both with and without the space in > > > >> int_curr_symbol. > > > >> > > > > >> > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > > > >> >> Hi Bill, > > > >> >> > > > >> >> And we need to update the VERSION number AFAIK > > > >> >> > > > >> >> Well the patch fixed a problem with failling tests? - so that the > > > >> >> tests are succesfull should suffice or? > > > >> >> > > > >> >> It seems as if there has been a glitch in the release of 1.51? > > > >> >> > > > >> >> jonasbn > > > >> >> > > > >> >> On 19/09/2006, at 22.13, Bill Ward wrote: > > > >> >> > > > >> >> > To make release 1.52 I think we need to do: > > > >> >> > > > > >> >> > 1. Add release date to CHANGES file > > > >> >> > 2. Update README file > > > >> >> > 3. Add a test case for the patch which was just committed > > > >> >> > > > > >> >> > Will someone do #3? I can do #1 and #2. Is there anything else > > > >> >> > I'm missing? > > > >> >> > > > > >> >> > This is the first time I've done a release via SourceForge > > > >> for any > > > >> >> > project so I need to learn how to do that. I'm planning to > > > >> >> upload the > > > >> >> > older versions as a test. Have any of you done that before? > > > >> >> Any tips > > > >> >> > if so? > > > >> >> > > > > >> >> > -- > > > >> >> > Help bring back the San Jose Earthquakes - http:// > > > >> >> > www.soccersiliconvalley.com/ > > > >> >> > > > > >> >> > > > > >> >> > > > >> --------------------------------------------------------------------- > > > >> >> - > > > >> >> > --- > > > >> >> > Take Surveys. Earn Cash. Influence the Future of IT > > > >> >> > Join SourceForge.net's Techsay panel and you'll get the > > > >> chance to > > > >> >> > share your > > > >> >> > opinions on IT & business topics through brief surveys -- and > > > >> earn > > > >> >> > cash > > > >> >> > http://www.techsay.com/default.php? > > > >> >> > page=join.php&p=sourceforge&CID=DEVDEV > > > >> >> > _______________________________________________ > > > >> >> > Number-Format-Developers mailing list > > > >> >> > Num...@li... > > > >> >> > https://lists.sourceforge.net/lists/listinfo/number-format- > > > >> >> developers > > > >> >> > > > >> >> > > > >> > > > > >> > > > > >> > -- > > > >> > Help bring back the San Jose Earthquakes - http:// > > > >> > www.soccersiliconvalley.com/ > > > >> > > > >> > > > > > > > > > > > > -- > > > > Help bring back the San Jose Earthquakes - http:// > > > > www.soccersiliconvalley.com/ > > > > > > > > > > > > -- > > Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ > > > > > -- > Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ > -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Jonas B. N. <jo...@gm...> - 2006-09-19 21:56:49
|
Well, Shouldn't we aim for backwards compability to the extent possible or can you say now that handling locales are not worth the effort prior to 5.8? jonasbn On 19/09/2006, at 23.51, Bill Ward wrote: > I just realized - we already have a line that says "require 5.008" so > nevermind all this business about backward compatibility. Let the > Test::More changes be commited. > > On 9/19/06, Bill Ward <bi...@wa...> wrote: >> OK. I thought I had granted you the necessary access to administer >> the tasks system. Let me look into it. >> >> On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: >> > Hi Bill, >> > >> > If that is the case, I say we wait a few days and try to >> eliminate as >> > many as the reported issues as possible. >> > >> > I still cannot create tasks on sf.net, or perhaps I just do not >> > understand how to, but else we could just go over the list I >> wroteup. >> > >> > As far as I can tell we are already two requests down :-) >> > >> > jonasbn >> > >> > On 19/09/2006, at 22.56, Bill Ward wrote: >> > >> > > Not sure how we would roll it back without access to the CVS >> > > repository itself...? >> > > Never mind ... let's just go to 1.6 as the next release. Are >> there >> > > any other low-hanging fruit type changes that anyone wants to >> make for >> > > this? >> > > >> > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: >> > >> Hi Bill, >> > >> >> > >> Well you do not have to use the revision number, I just >> expected you >> > >> auto-incremented the version number based on the revision >> number, I >> > >> can see now that this is not the case, we might as well call >> this >> > >> release 1.52 or we could roll back to 1.51 and try again? >> > >> >> > >> I will look into writing a test for the patch. >> > >> >> > >> jonasbn >> > >> >> > >> On 19/09/2006, at 22.46, Bill Ward wrote: >> > >> >> > >> > Damnit, the version number! I thought it was automatically >> > >> converted >> > >> > from the CVS version but I see that it is hard coded. So I >> guess >> > >> > version 1.52 now has to include CVS version 1.53. Ugh. >> > >> > >> > >> > As for the test, I like to follow the policy that any >> change made >> > >> > should have a test explicitly designed to cover that >> change. In >> > >> this >> > >> > case we could test both with and without the space in >> > >> int_curr_symbol. >> > >> > >> > >> > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: >> > >> >> Hi Bill, >> > >> >> >> > >> >> And we need to update the VERSION number AFAIK >> > >> >> >> > >> >> Well the patch fixed a problem with failling tests? - so >> that the >> > >> >> tests are succesfull should suffice or? >> > >> >> >> > >> >> It seems as if there has been a glitch in the release of >> 1.51? >> > >> >> >> > >> >> jonasbn >> > >> >> >> > >> >> On 19/09/2006, at 22.13, Bill Ward wrote: >> > >> >> >> > >> >> > To make release 1.52 I think we need to do: >> > >> >> > >> > >> >> > 1. Add release date to CHANGES file >> > >> >> > 2. Update README file >> > >> >> > 3. Add a test case for the patch which was just committed >> > >> >> > >> > >> >> > Will someone do #3? I can do #1 and #2. Is there >> anything else >> > >> >> > I'm missing? >> > >> >> > >> > >> >> > This is the first time I've done a release via SourceForge >> > >> for any >> > >> >> > project so I need to learn how to do that. I'm planning to >> > >> >> upload the >> > >> >> > older versions as a test. Have any of you done that >> before? >> > >> >> Any tips >> > >> >> > if so? >> > >> >> > >> > >> >> > -- >> > >> >> > Help bring back the San Jose Earthquakes - http:// >> > >> >> > www.soccersiliconvalley.com/ >> > >> >> > >> > >> >> > >> > >> >> >> > >> >> --------------------------------------------------------------------- >> > >> >> - >> > >> >> > --- >> > >> >> > Take Surveys. Earn Cash. Influence the Future of IT >> > >> >> > Join SourceForge.net's Techsay panel and you'll get the >> > >> chance to >> > >> >> > share your >> > >> >> > opinions on IT & business topics through brief surveys >> -- and >> > >> earn >> > >> >> > cash >> > >> >> > http://www.techsay.com/default.php? >> > >> >> > page=join.php&p=sourceforge&CID=DEVDEV >> > >> >> > _______________________________________________ >> > >> >> > Number-Format-Developers mailing list >> > >> >> > Num...@li... >> > >> >> > https://lists.sourceforge.net/lists/listinfo/number-format- >> > >> >> developers >> > >> >> >> > >> >> >> > >> > >> > >> > >> > >> > -- >> > >> > Help bring back the San Jose Earthquakes - http:// >> > >> > www.soccersiliconvalley.com/ >> > >> >> > >> >> > > >> > > >> > > -- >> > > Help bring back the San Jose Earthquakes - http:// >> > > www.soccersiliconvalley.com/ >> > >> > >> >> >> -- >> Help bring back the San Jose Earthquakes - http:// >> www.soccersiliconvalley.com/ >> > > > -- > Help bring back the San Jose Earthquakes - http:// > www.soccersiliconvalley.com/ |
From: Bill W. <bi...@wa...> - 2006-09-19 21:51:29
|
I just realized - we already have a line that says "require 5.008" so nevermind all this business about backward compatibility. Let the Test::More changes be commited. On 9/19/06, Bill Ward <bi...@wa...> wrote: > OK. I thought I had granted you the necessary access to administer > the tasks system. Let me look into it. > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > > Hi Bill, > > > > If that is the case, I say we wait a few days and try to eliminate as > > many as the reported issues as possible. > > > > I still cannot create tasks on sf.net, or perhaps I just do not > > understand how to, but else we could just go over the list I wroteup. > > > > As far as I can tell we are already two requests down :-) > > > > jonasbn > > > > On 19/09/2006, at 22.56, Bill Ward wrote: > > > > > Not sure how we would roll it back without access to the CVS > > > repository itself...? > > > Never mind ... let's just go to 1.6 as the next release. Are there > > > any other low-hanging fruit type changes that anyone wants to make for > > > this? > > > > > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > > >> Hi Bill, > > >> > > >> Well you do not have to use the revision number, I just expected you > > >> auto-incremented the version number based on the revision number, I > > >> can see now that this is not the case, we might as well call this > > >> release 1.52 or we could roll back to 1.51 and try again? > > >> > > >> I will look into writing a test for the patch. > > >> > > >> jonasbn > > >> > > >> On 19/09/2006, at 22.46, Bill Ward wrote: > > >> > > >> > Damnit, the version number! I thought it was automatically > > >> converted > > >> > from the CVS version but I see that it is hard coded. So I guess > > >> > version 1.52 now has to include CVS version 1.53. Ugh. > > >> > > > >> > As for the test, I like to follow the policy that any change made > > >> > should have a test explicitly designed to cover that change. In > > >> this > > >> > case we could test both with and without the space in > > >> int_curr_symbol. > > >> > > > >> > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > > >> >> Hi Bill, > > >> >> > > >> >> And we need to update the VERSION number AFAIK > > >> >> > > >> >> Well the patch fixed a problem with failling tests? - so that the > > >> >> tests are succesfull should suffice or? > > >> >> > > >> >> It seems as if there has been a glitch in the release of 1.51? > > >> >> > > >> >> jonasbn > > >> >> > > >> >> On 19/09/2006, at 22.13, Bill Ward wrote: > > >> >> > > >> >> > To make release 1.52 I think we need to do: > > >> >> > > > >> >> > 1. Add release date to CHANGES file > > >> >> > 2. Update README file > > >> >> > 3. Add a test case for the patch which was just committed > > >> >> > > > >> >> > Will someone do #3? I can do #1 and #2. Is there anything else > > >> >> > I'm missing? > > >> >> > > > >> >> > This is the first time I've done a release via SourceForge > > >> for any > > >> >> > project so I need to learn how to do that. I'm planning to > > >> >> upload the > > >> >> > older versions as a test. Have any of you done that before? > > >> >> Any tips > > >> >> > if so? > > >> >> > > > >> >> > -- > > >> >> > Help bring back the San Jose Earthquakes - http:// > > >> >> > www.soccersiliconvalley.com/ > > >> >> > > > >> >> > > > >> >> > > >> --------------------------------------------------------------------- > > >> >> - > > >> >> > --- > > >> >> > Take Surveys. Earn Cash. Influence the Future of IT > > >> >> > Join SourceForge.net's Techsay panel and you'll get the > > >> chance to > > >> >> > share your > > >> >> > opinions on IT & business topics through brief surveys -- and > > >> earn > > >> >> > cash > > >> >> > http://www.techsay.com/default.php? > > >> >> > page=join.php&p=sourceforge&CID=DEVDEV > > >> >> > _______________________________________________ > > >> >> > Number-Format-Developers mailing list > > >> >> > Num...@li... > > >> >> > https://lists.sourceforge.net/lists/listinfo/number-format- > > >> >> developers > > >> >> > > >> >> > > >> > > > >> > > > >> > -- > > >> > Help bring back the San Jose Earthquakes - http:// > > >> > www.soccersiliconvalley.com/ > > >> > > >> > > > > > > > > > -- > > > Help bring back the San Jose Earthquakes - http:// > > > www.soccersiliconvalley.com/ > > > > > > > -- > Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ > -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Bill W. <bi...@wa...> - 2006-09-19 21:05:51
|
OK. I thought I had granted you the necessary access to administer the tasks system. Let me look into it. On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > Hi Bill, > > If that is the case, I say we wait a few days and try to eliminate as > many as the reported issues as possible. > > I still cannot create tasks on sf.net, or perhaps I just do not > understand how to, but else we could just go over the list I wroteup. > > As far as I can tell we are already two requests down :-) > > jonasbn > > On 19/09/2006, at 22.56, Bill Ward wrote: > > > Not sure how we would roll it back without access to the CVS > > repository itself...? > > Never mind ... let's just go to 1.6 as the next release. Are there > > any other low-hanging fruit type changes that anyone wants to make for > > this? > > > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > >> Hi Bill, > >> > >> Well you do not have to use the revision number, I just expected you > >> auto-incremented the version number based on the revision number, I > >> can see now that this is not the case, we might as well call this > >> release 1.52 or we could roll back to 1.51 and try again? > >> > >> I will look into writing a test for the patch. > >> > >> jonasbn > >> > >> On 19/09/2006, at 22.46, Bill Ward wrote: > >> > >> > Damnit, the version number! I thought it was automatically > >> converted > >> > from the CVS version but I see that it is hard coded. So I guess > >> > version 1.52 now has to include CVS version 1.53. Ugh. > >> > > >> > As for the test, I like to follow the policy that any change made > >> > should have a test explicitly designed to cover that change. In > >> this > >> > case we could test both with and without the space in > >> int_curr_symbol. > >> > > >> > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > >> >> Hi Bill, > >> >> > >> >> And we need to update the VERSION number AFAIK > >> >> > >> >> Well the patch fixed a problem with failling tests? - so that the > >> >> tests are succesfull should suffice or? > >> >> > >> >> It seems as if there has been a glitch in the release of 1.51? > >> >> > >> >> jonasbn > >> >> > >> >> On 19/09/2006, at 22.13, Bill Ward wrote: > >> >> > >> >> > To make release 1.52 I think we need to do: > >> >> > > >> >> > 1. Add release date to CHANGES file > >> >> > 2. Update README file > >> >> > 3. Add a test case for the patch which was just committed > >> >> > > >> >> > Will someone do #3? I can do #1 and #2. Is there anything else > >> >> > I'm missing? > >> >> > > >> >> > This is the first time I've done a release via SourceForge > >> for any > >> >> > project so I need to learn how to do that. I'm planning to > >> >> upload the > >> >> > older versions as a test. Have any of you done that before? > >> >> Any tips > >> >> > if so? > >> >> > > >> >> > -- > >> >> > Help bring back the San Jose Earthquakes - http:// > >> >> > www.soccersiliconvalley.com/ > >> >> > > >> >> > > >> >> > >> --------------------------------------------------------------------- > >> >> - > >> >> > --- > >> >> > Take Surveys. Earn Cash. Influence the Future of IT > >> >> > Join SourceForge.net's Techsay panel and you'll get the > >> chance to > >> >> > share your > >> >> > opinions on IT & business topics through brief surveys -- and > >> earn > >> >> > cash > >> >> > http://www.techsay.com/default.php? > >> >> > page=join.php&p=sourceforge&CID=DEVDEV > >> >> > _______________________________________________ > >> >> > Number-Format-Developers mailing list > >> >> > Num...@li... > >> >> > https://lists.sourceforge.net/lists/listinfo/number-format- > >> >> developers > >> >> > >> >> > >> > > >> > > >> > -- > >> > Help bring back the San Jose Earthquakes - http:// > >> > www.soccersiliconvalley.com/ > >> > >> > > > > > > -- > > Help bring back the San Jose Earthquakes - http:// > > www.soccersiliconvalley.com/ > > -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Jonas B. N. <jo...@gm...> - 2006-09-19 21:02:23
|
Hi Bill, If that is the case, I say we wait a few days and try to eliminate as many as the reported issues as possible. I still cannot create tasks on sf.net, or perhaps I just do not understand how to, but else we could just go over the list I wroteup. As far as I can tell we are already two requests down :-) jonasbn On 19/09/2006, at 22.56, Bill Ward wrote: > Not sure how we would roll it back without access to the CVS > repository itself...? > Never mind ... let's just go to 1.6 as the next release. Are there > any other low-hanging fruit type changes that anyone wants to make for > this? > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: >> Hi Bill, >> >> Well you do not have to use the revision number, I just expected you >> auto-incremented the version number based on the revision number, I >> can see now that this is not the case, we might as well call this >> release 1.52 or we could roll back to 1.51 and try again? >> >> I will look into writing a test for the patch. >> >> jonasbn >> >> On 19/09/2006, at 22.46, Bill Ward wrote: >> >> > Damnit, the version number! I thought it was automatically >> converted >> > from the CVS version but I see that it is hard coded. So I guess >> > version 1.52 now has to include CVS version 1.53. Ugh. >> > >> > As for the test, I like to follow the policy that any change made >> > should have a test explicitly designed to cover that change. In >> this >> > case we could test both with and without the space in >> int_curr_symbol. >> > >> > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: >> >> Hi Bill, >> >> >> >> And we need to update the VERSION number AFAIK >> >> >> >> Well the patch fixed a problem with failling tests? - so that the >> >> tests are succesfull should suffice or? >> >> >> >> It seems as if there has been a glitch in the release of 1.51? >> >> >> >> jonasbn >> >> >> >> On 19/09/2006, at 22.13, Bill Ward wrote: >> >> >> >> > To make release 1.52 I think we need to do: >> >> > >> >> > 1. Add release date to CHANGES file >> >> > 2. Update README file >> >> > 3. Add a test case for the patch which was just committed >> >> > >> >> > Will someone do #3? I can do #1 and #2. Is there anything else >> >> > I'm missing? >> >> > >> >> > This is the first time I've done a release via SourceForge >> for any >> >> > project so I need to learn how to do that. I'm planning to >> >> upload the >> >> > older versions as a test. Have any of you done that before? >> >> Any tips >> >> > if so? >> >> > >> >> > -- >> >> > Help bring back the San Jose Earthquakes - http:// >> >> > www.soccersiliconvalley.com/ >> >> > >> >> > >> >> >> --------------------------------------------------------------------- >> >> - >> >> > --- >> >> > Take Surveys. Earn Cash. Influence the Future of IT >> >> > Join SourceForge.net's Techsay panel and you'll get the >> chance to >> >> > share your >> >> > opinions on IT & business topics through brief surveys -- and >> earn >> >> > cash >> >> > http://www.techsay.com/default.php? >> >> > page=join.php&p=sourceforge&CID=DEVDEV >> >> > _______________________________________________ >> >> > Number-Format-Developers mailing list >> >> > Num...@li... >> >> > https://lists.sourceforge.net/lists/listinfo/number-format- >> >> developers >> >> >> >> >> > >> > >> > -- >> > Help bring back the San Jose Earthquakes - http:// >> > www.soccersiliconvalley.com/ >> >> > > > -- > Help bring back the San Jose Earthquakes - http:// > www.soccersiliconvalley.com/ |
From: Bill W. <bi...@wa...> - 2006-09-19 20:56:53
|
Not sure how we would roll it back without access to the CVS repository itself...? Never mind ... let's just go to 1.6 as the next release. Are there any other low-hanging fruit type changes that anyone wants to make for this? On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > Hi Bill, > > Well you do not have to use the revision number, I just expected you > auto-incremented the version number based on the revision number, I > can see now that this is not the case, we might as well call this > release 1.52 or we could roll back to 1.51 and try again? > > I will look into writing a test for the patch. > > jonasbn > > On 19/09/2006, at 22.46, Bill Ward wrote: > > > Damnit, the version number! I thought it was automatically converted > > from the CVS version but I see that it is hard coded. So I guess > > version 1.52 now has to include CVS version 1.53. Ugh. > > > > As for the test, I like to follow the policy that any change made > > should have a test explicitly designed to cover that change. In this > > case we could test both with and without the space in int_curr_symbol. > > > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > >> Hi Bill, > >> > >> And we need to update the VERSION number AFAIK > >> > >> Well the patch fixed a problem with failling tests? - so that the > >> tests are succesfull should suffice or? > >> > >> It seems as if there has been a glitch in the release of 1.51? > >> > >> jonasbn > >> > >> On 19/09/2006, at 22.13, Bill Ward wrote: > >> > >> > To make release 1.52 I think we need to do: > >> > > >> > 1. Add release date to CHANGES file > >> > 2. Update README file > >> > 3. Add a test case for the patch which was just committed > >> > > >> > Will someone do #3? I can do #1 and #2. Is there anything else > >> > I'm missing? > >> > > >> > This is the first time I've done a release via SourceForge for any > >> > project so I need to learn how to do that. I'm planning to > >> upload the > >> > older versions as a test. Have any of you done that before? > >> Any tips > >> > if so? > >> > > >> > -- > >> > Help bring back the San Jose Earthquakes - http:// > >> > www.soccersiliconvalley.com/ > >> > > >> > > >> --------------------------------------------------------------------- > >> - > >> > --- > >> > Take Surveys. Earn Cash. Influence the Future of IT > >> > Join SourceForge.net's Techsay panel and you'll get the chance to > >> > share your > >> > opinions on IT & business topics through brief surveys -- and earn > >> > cash > >> > http://www.techsay.com/default.php? > >> > page=join.php&p=sourceforge&CID=DEVDEV > >> > _______________________________________________ > >> > Number-Format-Developers mailing list > >> > Num...@li... > >> > https://lists.sourceforge.net/lists/listinfo/number-format- > >> developers > >> > >> > > > > > > -- > > Help bring back the San Jose Earthquakes - http:// > > www.soccersiliconvalley.com/ > > -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Jonas B. N. <jo...@gm...> - 2006-09-19 20:52:52
|
Hi Bill, Well you do not have to use the revision number, I just expected you auto-incremented the version number based on the revision number, I can see now that this is not the case, we might as well call this release 1.52 or we could roll back to 1.51 and try again? I will look into writing a test for the patch. jonasbn On 19/09/2006, at 22.46, Bill Ward wrote: > Damnit, the version number! I thought it was automatically converted > from the CVS version but I see that it is hard coded. So I guess > version 1.52 now has to include CVS version 1.53. Ugh. > > As for the test, I like to follow the policy that any change made > should have a test explicitly designed to cover that change. In this > case we could test both with and without the space in int_curr_symbol. > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: >> Hi Bill, >> >> And we need to update the VERSION number AFAIK >> >> Well the patch fixed a problem with failling tests? - so that the >> tests are succesfull should suffice or? >> >> It seems as if there has been a glitch in the release of 1.51? >> >> jonasbn >> >> On 19/09/2006, at 22.13, Bill Ward wrote: >> >> > To make release 1.52 I think we need to do: >> > >> > 1. Add release date to CHANGES file >> > 2. Update README file >> > 3. Add a test case for the patch which was just committed >> > >> > Will someone do #3? I can do #1 and #2. Is there anything else >> > I'm missing? >> > >> > This is the first time I've done a release via SourceForge for any >> > project so I need to learn how to do that. I'm planning to >> upload the >> > older versions as a test. Have any of you done that before? >> Any tips >> > if so? >> > >> > -- >> > Help bring back the San Jose Earthquakes - http:// >> > www.soccersiliconvalley.com/ >> > >> > >> --------------------------------------------------------------------- >> - >> > --- >> > Take Surveys. Earn Cash. Influence the Future of IT >> > Join SourceForge.net's Techsay panel and you'll get the chance to >> > share your >> > opinions on IT & business topics through brief surveys -- and earn >> > cash >> > http://www.techsay.com/default.php? >> > page=join.php&p=sourceforge&CID=DEVDEV >> > _______________________________________________ >> > Number-Format-Developers mailing list >> > Num...@li... >> > https://lists.sourceforge.net/lists/listinfo/number-format- >> developers >> >> > > > -- > Help bring back the San Jose Earthquakes - http:// > www.soccersiliconvalley.com/ |
From: Bill W. <bi...@wa...> - 2006-09-19 20:46:07
|
Damnit, the version number! I thought it was automatically converted from the CVS version but I see that it is hard coded. So I guess version 1.52 now has to include CVS version 1.53. Ugh. As for the test, I like to follow the policy that any change made should have a test explicitly designed to cover that change. In this case we could test both with and without the space in int_curr_symbol. On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > Hi Bill, > > And we need to update the VERSION number AFAIK > > Well the patch fixed a problem with failling tests? - so that the > tests are succesfull should suffice or? > > It seems as if there has been a glitch in the release of 1.51? > > jonasbn > > On 19/09/2006, at 22.13, Bill Ward wrote: > > > To make release 1.52 I think we need to do: > > > > 1. Add release date to CHANGES file > > 2. Update README file > > 3. Add a test case for the patch which was just committed > > > > Will someone do #3? I can do #1 and #2. Is there anything else > > I'm missing? > > > > This is the first time I've done a release via SourceForge for any > > project so I need to learn how to do that. I'm planning to upload the > > older versions as a test. Have any of you done that before? Any tips > > if so? > > > > -- > > Help bring back the San Jose Earthquakes - http:// > > www.soccersiliconvalley.com/ > > > > ---------------------------------------------------------------------- > > --- > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to > > share your > > opinions on IT & business topics through brief surveys -- and earn > > cash > > http://www.techsay.com/default.php? > > page=join.php&p=sourceforge&CID=DEVDEV > > _______________________________________________ > > Number-Format-Developers mailing list > > Num...@li... > > https://lists.sourceforge.net/lists/listinfo/number-format-developers > > -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Jonas B. N. <jo...@gm...> - 2006-09-19 20:21:42
|
Hi Bill, And we need to update the VERSION number AFAIK Well the patch fixed a problem with failling tests? - so that the tests are succesfull should suffice or? It seems as if there has been a glitch in the release of 1.51? jonasbn On 19/09/2006, at 22.13, Bill Ward wrote: > To make release 1.52 I think we need to do: > > 1. Add release date to CHANGES file > 2. Update README file > 3. Add a test case for the patch which was just committed > > Will someone do #3? I can do #1 and #2. Is there anything else > I'm missing? > > This is the first time I've done a release via SourceForge for any > project so I need to learn how to do that. I'm planning to upload the > older versions as a test. Have any of you done that before? Any tips > if so? > > -- > Help bring back the San Jose Earthquakes - http:// > www.soccersiliconvalley.com/ > > ---------------------------------------------------------------------- > --- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to > share your > opinions on IT & business topics through brief surveys -- and earn > cash > http://www.techsay.com/default.php? > page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Number-Format-Developers mailing list > Num...@li... > https://lists.sourceforge.net/lists/listinfo/number-format-developers |
From: Bill W. <bi...@wa...> - 2006-09-19 20:13:59
|
To make release 1.52 I think we need to do: 1. Add release date to CHANGES file 2. Update README file 3. Add a test case for the patch which was just committed Will someone do #3? I can do #1 and #2. Is there anything else I'm missing? This is the first time I've done a release via SourceForge for any project so I need to learn how to do that. I'm planning to upload the older versions as a test. Have any of you done that before? Any tips if so? -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Jonas B. N. <jo...@gm...> - 2006-09-19 20:05:08
|
Hi, According to Module::CoreList (latest and greatest) Test::More and Test::Simple are where both included in Core distribution from: 5.007003 (5.7.3) if we fall back to using the regular Test module, which is ok, it was included in the Core distribution from: 5.005 jonasbn On 19/09/2006, at 21.50, Bill Ward wrote: > On 9/19/06, Darren Chamberlain <dl...@se...> wrote: >> * Bill Ward <bill at wards.net> [2006/09/19 11:34]: >>> I was talking with Jonas on AIM today... here's the gist: >>> >>> 1. He has a patch ready for >>> https://rt.cpan.org/Public/Bug/Display.html?id=21382 - that will >>> produce Format.pm version 1.52 when he commits it >> >> Ooops -- I just committed his patch, after he mentioned it in the >> last >> email. Since it had been sitting for two weeks, I assumed he wasn't >> able to commit it. > > Sounds like it worked out fine since you were both committing the same > patch. But maybe in the future it would be better to discuss changes > by email before committing them, especially as long as we're still > tying CVS versions to release versions. > >>> 3. We will switch the tests to use Test::More and clean up the >>> locale >>> support, since that was written when Perl had really poor locale >>> support and is causing most of the bugs these days. This will be >>> release 2.0 and will also include any needed API changes and bug >>> fixes. >> >> I started updating the tests. so far I've done format_bytes.t. It's >> functionally the same as the previous version, just reworked to use >> Test::More. >> >> I'll wait to commit this, though. > > Yes. For now I think it's important that we don't break compatibility > with older versions of Perl that may not have Test::More included. > Jonas is investigating to see what version of Perl first included > Test::More. We'll use that as the minimum requirement for 2.0, > assuming that is no older than the version (5.6 I think) that > implemented the full locale support. > > (The reason locale support is so confusing in N::F is because I wrote > it for an older version of Perl that had very poor locale support.) > > --Bill. > > -- > Help bring back the San Jose Earthquakes - http:// > www.soccersiliconvalley.com/ > > ---------------------------------------------------------------------- > --- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to > share your > opinions on IT & business topics through brief surveys -- and earn > cash > http://www.techsay.com/default.php? > page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Number-Format-Developers mailing list > Num...@li... > https://lists.sourceforge.net/lists/listinfo/number-format-developers |
From: Bill W. <bi...@wa...> - 2006-09-19 19:52:11
|
On 9/19/06, Darren Chamberlain <dl...@se...> wrote: > * Bill Ward <bill at wards.net> [2006/09/19 11:34]: > > I was talking with Jonas on AIM today... here's the gist: > > > > 1. He has a patch ready for > > https://rt.cpan.org/Public/Bug/Display.html?id=21382 - that will > > produce Format.pm version 1.52 when he commits it > > Ooops -- I just committed his patch, after he mentioned it in the last > email. Since it had been sitting for two weeks, I assumed he wasn't > able to commit it. Sounds like it worked out fine since you were both committing the same patch. But maybe in the future it would be better to discuss changes by email before committing them, especially as long as we're still tying CVS versions to release versions. > > 3. We will switch the tests to use Test::More and clean up the locale > > support, since that was written when Perl had really poor locale > > support and is causing most of the bugs these days. This will be > > release 2.0 and will also include any needed API changes and bug > > fixes. > > I started updating the tests. so far I've done format_bytes.t. It's > functionally the same as the previous version, just reworked to use > Test::More. > > I'll wait to commit this, though. Yes. For now I think it's important that we don't break compatibility with older versions of Perl that may not have Test::More included. Jonas is investigating to see what version of Perl first included Test::More. We'll use that as the minimum requirement for 2.0, assuming that is no older than the version (5.6 I think) that implemented the full locale support. (The reason locale support is so confusing in N::F is because I wrote it for an older version of Perl that had very poor locale support.) --Bill. -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Jonas B. N. <jo...@gm...> - 2006-09-19 18:43:14
|
Ok, that is why my diffs report nothing, I got really confused - well we are on our way and that is what is important... jonasbn On 19/09/2006, at 20.38, Darren Chamberlain wrote: > * Bill Ward <bill at wards.net> [2006/09/19 11:34]: >> I was talking with Jonas on AIM today... here's the gist: >> >> 1. He has a patch ready for >> https://rt.cpan.org/Public/Bug/Display.html?id=21382 - that will >> produce Format.pm version 1.52 when he commits it > > Ooops -- I just committed his patch, after he mentioned it in the last > email. Since it had been sitting for two weeks, I assumed he wasn't > able to commit it. > >> 3. We will switch the tests to use Test::More and clean up the locale >> support, since that was written when Perl had really poor locale >> support and is causing most of the bugs these days. This will be >> release 2.0 and will also include any needed API changes and bug >> fixes. > > I started updating the tests. so far I've done format_bytes.t. It's > functionally the same as the previous version, just reworked to use > Test::More. > > I'll wait to commit this, though. > > (darren) > > -- > Usenet is like a herd of performing elephants with diarrhea; massive, > difficult to redirect, awe-inspiring, entertaining, and a source of > mind-boggling amounts of excrement when you least expect it. > -- Eugene Spafford > ---------------------------------------------------------------------- > --- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to > share your > opinions on IT & business topics through brief surveys -- and earn > cash > http://www.techsay.com/default.php? > page=join.php&p=sourceforge&CID=DEVDEV________________________________ > _______________ > Number-Format-Developers mailing list > Num...@li... > https://lists.sourceforge.net/lists/listinfo/number-format-developers |
From: Darren C. <dl...@se...> - 2006-09-19 18:38:06
|
* Bill Ward <bill at wards.net> [2006/09/19 11:34]: > I was talking with Jonas on AIM today... here's the gist: >=20 > 1. He has a patch ready for > https://rt.cpan.org/Public/Bug/Display.html?id=3D21382 - that will > produce Format.pm version 1.52 when he commits it Ooops -- I just committed his patch, after he mentioned it in the last email. Since it had been sitting for two weeks, I assumed he wasn't able to commit it. > 3. We will switch the tests to use Test::More and clean up the locale > support, since that was written when Perl had really poor locale > support and is causing most of the bugs these days. This will be > release 2.0 and will also include any needed API changes and bug > fixes. I started updating the tests. so far I've done format_bytes.t. It's functionally the same as the previous version, just reworked to use Test::More. I'll wait to commit this, though. (darren) --=20 Usenet is like a herd of performing elephants with diarrhea; massive, difficult to redirect, awe-inspiring, entertaining, and a source of mind-boggling amounts of excrement when you least expect it. -- Eugene Spafford |
From: Darren C. <dl...@se...> - 2006-09-19 18:34:35
|
* Jonas B. Nielsen <jonasbn at gmail.com> [2006/09/19 20:21]: > We have the patch for the failling tests handy, we just need to patch =20 > and release, it can be obtained from rt.cpan.org >=20 > https://rt.cpan.org/Ticket/Display.html?id=3D21382 Applied. (darren) --=20 It has long been an axiom of mine that the little things are infinitely the most important. -- Arthur Conan Coyle |
From: Bill W. <bi...@wa...> - 2006-09-19 18:34:07
|
I was talking with Jonas on AIM today... here's the gist: 1. He has a patch ready for https://rt.cpan.org/Public/Bug/Display.html?id=21382 - that will produce Format.pm version 1.52 when he commits it 2. We will make minor fixes to the test suite and docs for a 1.52 release which will be the first release done via Sourceforge. 3. We will switch the tests to use Test::More and clean up the locale support, since that was written when Perl had really poor locale support and is causing most of the bugs these days. This will be release 2.0 and will also include any needed API changes and bug fixes. 4. Up until now, CVS file versions on Format.pm have been the source of the version numbering for the releases. That made sense while I was the only developer but now we have to decouple that. 1.52 will be the last version where Format.pm's version is the release number. After that we can just manually increment it and not have it be derived from CVS. Any comments or concerns? -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Jonas B. N. <jo...@gm...> - 2006-09-19 18:22:19
|
Hi Darren, We have the patch for the failling tests handy, we just need to patch and release, it can be obtained from rt.cpan.org https://rt.cpan.org/Ticket/Display.html?id=21382 jonasbn On 19/09/2006, at 14.10, Darren Chamberlain wrote: > The latest CVS has test failures in t/format_price.t. It appears that > the tests are expecting Number::Format to emit a space after the > currency symbol: > > print "not " unless ($usd->format_price(123456.51) eq 'USD > 123,456.51'); > print "ok 2\n"; > > In reality, there is no space: > > $ perl -Mblib -MNumber::Format -wle '$f = Number::Format->new(- > int_curr_symbol => "USD"); print $f->format_price(123456.51)' > USD123,456.51 > > Is this an error in the tests or in the output from format_price? > > Also, is there a reason the tests are not using Test::Simple? > > (darren) > > -- > I have had my solutions for a long time; but I do not yet know how I > am to arrive at them. > -- Karl F. Gauss > ---------------------------------------------------------------------- > --- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to > share your > opinions on IT & business topics through brief surveys -- and earn > cash > http://www.techsay.com/default.php? > page=join.php&p=sourceforge&CID=DEVDEV________________________________ > _______________ > Number-Format-Developers mailing list > Num...@li... > https://lists.sourceforge.net/lists/listinfo/number-format-developers |
From: Bill W. <bi...@wa...> - 2006-09-19 16:18:37
|
I think Test::Simple was written after the Number::Format tests were already done. This module is a few years old. If you want to convert them to Test::Simple I have no issue with that. On 9/19/06, Darren Chamberlain <dl...@se...> wrote: > The latest CVS has test failures in t/format_price.t. It appears that > the tests are expecting Number::Format to emit a space after the > currency symbol: > > print "not " unless ($usd->format_price(123456.51) eq 'USD 123,456.51'); > print "ok 2\n"; > > In reality, there is no space: > > $ perl -Mblib -MNumber::Format -wle '$f = Number::Format->new(-int_curr_symbol => "USD"); print $f->format_price(123456.51)' > USD123,456.51 > > Is this an error in the tests or in the output from format_price? > > Also, is there a reason the tests are not using Test::Simple? > > (darren) > > -- > I have had my solutions for a long time; but I do not yet know how I > am to arrive at them. > -- Karl F. Gauss > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys -- and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > _______________________________________________ > Number-Format-Developers mailing list > Num...@li... > https://lists.sourceforge.net/lists/listinfo/number-format-developers > > > > -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |
From: Darren C. <dl...@se...> - 2006-09-19 12:10:21
|
The latest CVS has test failures in t/format_price.t. It appears that the tests are expecting Number::Format to emit a space after the currency symbol: print "not " unless ($usd->format_price(123456.51) eq 'USD 123,456.51'); print "ok 2\n"; In reality, there is no space: $ perl -Mblib -MNumber::Format -wle '$f =3D Number::Format->new(-int_curr= _symbol =3D> "USD"); print $f->format_price(123456.51)' USD123,456.51 Is this an error in the tests or in the output from format_price? Also, is there a reason the tests are not using Test::Simple? (darren) --=20 I have had my solutions for a long time; but I do not yet know how I am to arrive at them. -- Karl F. Gauss |
From: Bill W. <bi...@wa...> - 2006-09-19 05:46:42
|
This is the first email sent to the new Number-Format-Developers mailing list. Let's use this list to discuss work on the Number::Format project. |