Re: [Number::Format] Release 1.52
Brought to you by:
billward
From: Bill W. <bi...@wa...> - 2006-09-19 20:56:53
|
Not sure how we would roll it back without access to the CVS repository itself...? Never mind ... let's just go to 1.6 as the next release. Are there any other low-hanging fruit type changes that anyone wants to make for this? On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > Hi Bill, > > Well you do not have to use the revision number, I just expected you > auto-incremented the version number based on the revision number, I > can see now that this is not the case, we might as well call this > release 1.52 or we could roll back to 1.51 and try again? > > I will look into writing a test for the patch. > > jonasbn > > On 19/09/2006, at 22.46, Bill Ward wrote: > > > Damnit, the version number! I thought it was automatically converted > > from the CVS version but I see that it is hard coded. So I guess > > version 1.52 now has to include CVS version 1.53. Ugh. > > > > As for the test, I like to follow the policy that any change made > > should have a test explicitly designed to cover that change. In this > > case we could test both with and without the space in int_curr_symbol. > > > > On 9/19/06, Jonas B. Nielsen <jo...@gm...> wrote: > >> Hi Bill, > >> > >> And we need to update the VERSION number AFAIK > >> > >> Well the patch fixed a problem with failling tests? - so that the > >> tests are succesfull should suffice or? > >> > >> It seems as if there has been a glitch in the release of 1.51? > >> > >> jonasbn > >> > >> On 19/09/2006, at 22.13, Bill Ward wrote: > >> > >> > To make release 1.52 I think we need to do: > >> > > >> > 1. Add release date to CHANGES file > >> > 2. Update README file > >> > 3. Add a test case for the patch which was just committed > >> > > >> > Will someone do #3? I can do #1 and #2. Is there anything else > >> > I'm missing? > >> > > >> > This is the first time I've done a release via SourceForge for any > >> > project so I need to learn how to do that. I'm planning to > >> upload the > >> > older versions as a test. Have any of you done that before? > >> Any tips > >> > if so? > >> > > >> > -- > >> > Help bring back the San Jose Earthquakes - http:// > >> > www.soccersiliconvalley.com/ > >> > > >> > > >> --------------------------------------------------------------------- > >> - > >> > --- > >> > Take Surveys. Earn Cash. Influence the Future of IT > >> > Join SourceForge.net's Techsay panel and you'll get the chance to > >> > share your > >> > opinions on IT & business topics through brief surveys -- and earn > >> > cash > >> > http://www.techsay.com/default.php? > >> > page=join.php&p=sourceforge&CID=DEVDEV > >> > _______________________________________________ > >> > Number-Format-Developers mailing list > >> > Num...@li... > >> > https://lists.sourceforge.net/lists/listinfo/number-format- > >> developers > >> > >> > > > > > > -- > > Help bring back the San Jose Earthquakes - http:// > > www.soccersiliconvalley.com/ > > -- Help bring back the San Jose Earthquakes - http://www.soccersiliconvalley.com/ |