Several problems with the GIT version

[Helmut Jarausch]

Hi,
first of all many thanks for your work on nufraw.
I have three problems with the current GIT version (problems 2 and 3 occur with version 0.39, as well)

1) the file icons/film-24.png seems to be broken. I had to regenerate it from film.svg.
2) I've tried lens correction. Nufraw detected my camera (FZ1000), I selected PanoTools lens model and entered the three parameters (which have been check with several other progrograms). But it hasn't any effect (on the preview, at least). I cannot import the image into Gimp, because of problem 3 below.
3) This seems to be a difficult problem. I hope someone has an idea on what's going wrong. I'm using the GIT version of Gimp together with the GIT version of GEGL. Some plugins caused segment faults after saving an image and NUFRAW still causes segment faults: /usr/lib64/gimp/2.0/plug-ins/nufraw-gimp: fatal error: Segmentation fault
/usr/lib64/gimp/2.0/plug-ins/nufraw-gimp (pid:9820): [E]xit, [H]alt, show [S]tack trace or [P]roceed: ^C/usr/lib64/gimp/2.0/plug-ins/nufraw-gimp terminated: Interrupt
/usr/lib64/gimp/2.0/plug-ins/script-fu terminated: Interrupt

Thread 1 "gimp" received signal SIGINT, Interrupt.
0x00007ffff31d3f4d in poll () from /lib64/libc.so.6
(gdb) where

0 0x00007ffff31d3f4d in poll () from /lib64/libc.so.6

1 0x00007ffff3e2f236 in g_main_context_iterate.isra ()

from /usr/lib64/libglib-2.0.so.0

2 0x00007ffff3e2f612 in g_main_loop_run () from /usr/lib64/libglib-2.0.so.0

3 0x00005555559006b4 in gimp_plug_in_manager_call_run (

manager=0x555555fec030, context=context@entry=0x5555568cf310, 
progress=progress@entry=0x555558070a20, procedure=0x555558a72c60, 
args=args@entry=0x7fff9c002600, synchronous=synchronous@entry=1, 
display=0x0) at gimppluginmanager-call.c:280

4 0x00005555558f86bf in gimp_plug_in_procedure_execute (

procedure=0x555558a72c60, gimp=0x555556550180, context=0x5555568cf310, 
progress=0x555558070a20, args=0x7fff9c002600, error=0x7fffffffc8c8)
at gimppluginprocedure.c:411

5 0x00005555558ea69c in gimp_procedure_execute (

procedure=procedure@entry=0x555558a72c60, gimp=0x555556550180, 
context=0x5555568cf310, context@entry=0x55555659e210, 
progress=progress@entry=0x555558070a20, args=args@entry=0x7fff9c002600, 
error=error@entry=0x7fffffffc8c8) at gimpprocedure.c:418

6 0x00005555558e2c32 in gimp_pdb_execute_procedure_by_name_args (

pdb=pdb@entry=0x55555653c780, context=context@entry=0x55555659e210, 
progress=progress@entry=0x555558070a20, error=error@entry=0x7fffffffc8c8, 
name=name@entry=0x555558a74c60 "file-nufraw-load", 
args=args@entry=0x7fff9c002600) at gimppdb.c:322

Until recently all Gimp 'export-as' commands did cause (a similar) segmentation fault. Luckily this went away since a few days (and I hope it won't come back). I have the feeling it has something to do with threading. Unfortunately I have no idea how to debug this. Currently Gimp's plugin manager catches the segmentation fault and displays the messages above. (I had to <ctrl> C to get into the debugger for the trace)

Many thanks for some hints,
Helmut

[Helmut Jarausch]

Please apply the following patch. Without it this plugin crashes when it calls lf_modifier_destroy with a non-existent object.
--- nufraw_lensfun.cc.ORIG 2017-02-26 11:51:28.546834402 +0100
+++ nufraw_lensfun.cc 2017-02-26 11:51:28.546834402 +0100
@@ -868,7 +868,7 @@
lfLensType(targetLensGeometry.Index()),
UF_LF_TRANSFORM | LF_MODIFY_VIGNETTING, reverse);
if ((uf->modFlags & (UF_LF_TRANSFORM | LF_MODIFY_VIGNETTING)) == 0) {
- uf->modifier->Destroy();
+ if (uf->modifier != NULL) uf->modifier->Destroy();
uf->modifier = NULL;
}
}
--- nufraw_interface.c.ORIG 2017-02-26 12:03:38.143882057 +0100
+++ nufraw_interface.c 2017-02-26 12:07:17.034896354 +0100
@@ -753,8 +753,8 @@
g_free(uf->displayProfile);
g_free(uf->RawHistogram);
#ifdef HAVE_LENSFUN
- lf_modifier_destroy(uf->TCAmodifier);
- lf_modifier_destroy(uf->modifier);
+ if (uf->TCAmodifier != NULL) lf_modifier_destroy(uf->TCAmodifier);
+ if (uf->modifier != NULL) lf_modifier_destroy(uf->modifier);
#endif
ufobject_delete(uf->conf->ufobject);
g_free(uf->conf);

[Helmut Jarausch]

The lensfun correction is still NOT applied to the image.

[Partha]

Helmut, pardon my ignorance. What OS are you using here? I have no segfault with Windows or Mac when a camera raw image is opened with nufraw-gimp.