Hello!
I hope you noticed that there is a new patch in the "Patches" section. I am going to use nss-mysql in an environment where I need a few features which aren't yet in the library. This is e.g. setting the gid of a user by using a column in the mysql table instead of using a default value.
So the first thing to do surely was to look at the source code, but I noticed a few things which could be done better, or at least in a more "readable" fashion. The TODO about adding lots of comments is also true, btw.
Regarding the readability of the source code I would like to know if there is a different way of putting together SQL queries, other than how you do it. Maybe a function could be implemented, - let's call it sqlprintf() for example - which does the malloc'ing automatically and returns a ready-to-use string?
Please forgive me if all the above is completely useless stuff, I have never really worked with other people's source code.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've noticed your patch. But (as I've written to you :-) ) I cannot download it.
I think the GID stuff is really required, more comments too.
And I find that the sqlprint is a great idea.
If you want, I can add you as a developer of the project.
Regards,
Guillaume.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello!
I hope you noticed that there is a new patch in the "Patches" section. I am going to use nss-mysql in an environment where I need a few features which aren't yet in the library. This is e.g. setting the gid of a user by using a column in the mysql table instead of using a default value.
So the first thing to do surely was to look at the source code, but I noticed a few things which could be done better, or at least in a more "readable" fashion. The TODO about adding lots of comments is also true, btw.
Regarding the readability of the source code I would like to know if there is a different way of putting together SQL queries, other than how you do it. Maybe a function could be implemented, - let's call it sqlprintf() for example - which does the malloc'ing automatically and returns a ready-to-use string?
Please forgive me if all the above is completely useless stuff, I have never really worked with other people's source code.
Hi,
I've noticed your patch. But (as I've written to you :-) ) I cannot download it.
I think the GID stuff is really required, more comments too.
And I find that the sqlprint is a great idea.
If you want, I can add you as a developer of the project.
Regards,
Guillaume.
Yes, it would be great if you added me as a developer! I can't promise anything, but I am definitely interested in adding some features to nss-mysql.
Thanks,
Marcel