Menu

#82 ChangeUI discrepancy

closed-fixed
NSIS (71)
5
2005-11-05
2005-11-04
No

The command:

makensis /cmdhelp changeui

displays:

Usage: ChangeUI [/RTL] (all|dlg_id) ui_file.exe

HOWEVER:
Looking at script.cpp, I see that the /RTL flag is not
processed at all.
So... is the cmdhelp incorrect or is the implementation
incorrect?

Discussion

  • Sunil Kamath

    Sunil Kamath - 2005-11-04

    Logged In: YES
    user_id=778767

    Also, the following line in tokens.cpp is wrong:

    {TOK_CHANGEUI,"ChangeUI",1,1,"[/RTL] (all|dlg_id)
    ui_file.exe",TP_GLOBAL},

    It should be:

    {TOK_CHANGEUI,"ChangeUI",2,0,"(all|dlg_id)
    ui_file.exe",TP_GLOBAL},

    I am not going to attach a formal patch for this since it is
    only a one-line fix.

     
  • Amir Szekely

    Amir Szekely - 2005-11-05
    • labels: --> NSIS
    • assigned_to: nobody --> kichik
    • status: open --> closed-fixed
     
  • Amir Szekely

    Amir Szekely - 2005-11-05

    Logged In: YES
    user_id=584402

    Thanks, applied.

     

Log in to post a comment.