Menu

#145 Language selection dialog doesn't display all languages

closed-accepted
Modern UI (11)
5
2007-06-05
2007-05-24
Anonymous
No

The Russian language is not shown in the language selection windows when compiling with the NSIS versions 2.26 and 2.27 (with 2.25 and previous versions works).

My code fragment:
-----------------------------------
!insertmacro MUI_LANGUAGE "German"
!insertmacro MUI_LANGUAGE "English"
!insertmacro MUI_LANGUAGE "French"
!insertmacro MUI_LANGUAGE "Russian"

!insertmacro MUI_RESERVEFILE_LANGDLL
!insertmacro MUI_LANGDLL_DISPLAY
-----------------------------------

M y e m a i l:
Username: demeterd
Domain: gmx.net

Discussion

  • Amir Szekely

    Amir Szekely - 2007-05-24

    Logged In: YES
    user_id=584402
    Originator: NO

    The language selection dialog no longer shows languages that are not compatible with the user's codepage. That prevents the user from getting gebrish for text.

     
  • Amir Szekely

    Amir Szekely - 2007-05-24
    • labels: 458220 --> 458223
    • assigned_to: nobody --> kichik
    • status: open --> closed-invalid
     
  • Nobody/Anonymous

    Logged In: NO

    Thank you for your answer!

    demeter

     
  • Nobody/Anonymous

    Logged In: NO

    New question: can be this feature turned off?
    Thanks!

     
  • Amir Szekely

    Amir Szekely - 2007-05-30

    Logged In: YES
    user_id=584402
    Originator: NO

    No, not currently. If you want to disable for testing, you should consider just changing the registry key that holds the last selected language instead or use StrCpy $LANGUAGE in .onInit.

    But if you really want to disable it, you'd have to modify Contrib\Modern UI\System.nsh. If you submit that as a patch which makes it optional, I'll include it.

     
  • Nobody/Anonymous

    Logged In: NO

    Thank you very much for your answers!

    I have modified the file System.nsh (ver. 2.27). When my new constant MUI_LANGDLL_SHOW_ALL_LANGUAGES is defined then all the languages will be shown in the language selection window.
    I don't know whether this solution is right and elegant enough...
    (I cannot submit the file so I will send it to your mail address)

    demeter

     
  • Amir Szekely

    Amir Szekely - 2007-06-05
    • summary: Bug language selection window --> Language selection dialog doesn't display all languages
    • labels: 458223 --> Modern UI
    • milestone: 378423 -->
    • status: closed-invalid --> closed-accepted
     
  • Amir Szekely

    Amir Szekely - 2007-06-05

    demeter's patch

     
  • Amir Szekely

    Amir Szekely - 2007-06-05

    Logged In: YES
    user_id=584402
    Originator: NO

    Thanks, applied.
    File Added: System.nsh

     
  • Amir Szekely

    Amir Szekely - 2007-06-05

    Logged In: YES
    user_id=584402
    Originator: NO

    I've renamed MUI_LANGDLL_SHOW_ALL_LANGUAGES to MUI_LANGDLL_ALLLANGUAGES to match the style of other defines.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.