[NSIS-Bugs] [ nsis-Patches-2680832 ] NSIS_PACKEDVER define

[SourceForge.net <no...@so...>]

Patches item #2680832, was opened at 2009-03-10 17:40
Message generated for change (Settings changed) made by anders_k
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373087&aid=2680832&group_id=22049

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Anders (anders_k)
Assigned to: Nobody/Anonymous (nobody)
Summary: NSIS_PACKEDVER define

Initial Comment:
We need a real version number define scripts can use with !if, and the existing version define format does not cut it.

(Diff against 5949 (trunk))

\SConstruct:

175a176,180
> 
> # NSIS_PACKEDVER=0xMMmmmbbb
> if defenv.has_key('VER_MAJOR'):
> 	defenv.Append(NSIS_CPPDEFINES = [('NSIS_PACKEDVER', '"0x%0.2d%0.3d%0.3d"' % (int(defenv['VER_MAJOR']),int(defenv['VER_MINOR']),int(defenv['VER_BUILD'])) )])
> 


We are already almost half the way to 100 with the minor version, and 3.0 is not really on the map AFAIK so I provide space for minor versions up to 999. I did not go with 0xMMmmbbrr because we do not seem to use the build or revision version fields at all, even for quick bug fix releases. But just using 0xMMMMmmmm would really paint us into a corner if we decide to start using the other fields.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373087&aid=2680832&group_id=22049