Re: [NSIS-devel] Can I remove unnecessary old code from *.nsh files?

[Amir S. <ki...@gm...>]

Fixed with r6287.

On Wed, Dec 12, 2012 at 10:28 AM, Amir Szekely <ki...@gm...> wrote:
> Build definitions are passed to the script so it can work with
> different NSIS builds.
> Look in SConstruct for nsis-defines.h that's written to build/urelease/config/.
>
> Now, as for the two different strings. They are necessary.
> When that config is set to True, nothing happens when you position
> your mouse over a component.
> The only way to get a description for the component is to click it.
>
> I checked and there are only two language files where the text is
> actually different.
> This was OK before the language files were moved from Contrib\Modern
> UI\Language Files to Contrib\Language Files.
> The problem is with commits 5228 that added the new, defected,
> language files and 5229 that remove the old ones.
> The old MUI_INNERTEXT_COMPONENTS_DESCRIPTION_INFO should be copied
> back from the old files.
>
> On Wed, Dec 12, 2012 at 5:39 AM, Oleksandr Gavenko <gav...@gm...> wrote:
>> During checking Ukrainian translation side by side with English.nsh I found
>> this block of code:
>>
>>   !ifndef NSIS_CONFIG_COMPONENTPAGE_ALTERNATIVE
>>     ${LangFileString} MUI_INNERTEXT_COMPONENTS_DESCRIPTION_INFO "Position your mouse over a component to see its description."
>>   !else
>>     ${LangFileString} MUI_INNERTEXT_COMPONENTS_DESCRIPTION_INFO "Position your mouse over a component to see its description."
>>   !endif
>>
>> I grep for 'NSIS_CONFIG_COMPONENTPAGE_ALTERNATIVE' keyword into project:
>>
>>   $ ack-grep NSIS_CONFIG_COMPONENTPAGE_ALTERNATIVE
>>
>>   Source/exehead/Ui.c
>>   1225:#ifdef NSIS_CONFIG_COMPONENTPAGE_ALTERNATIVE
>>   1259:#ifndef NSIS_CONFIG_COMPONENTPAGE_ALTERNATIVE
>>
>>   SCons/config.py
>>   65:    'NSIS_CONFIG_COMPONENTPAGE_ALTERNATIVE',
>>   460:AddBoolDefine('NSIS_CONFIG_COMPONENTPAGE_ALTERNATIVE')
>>
>>   ...
>>   Contrib/Language files/English.nsh
>>   48:  !ifndef NSIS_CONFIG_COMPONENTPAGE_ALTERNATIVE
>>   ...
>>   *** 61 time repeated in other .nsh files ***
>>   ...
>>
>> I am not expert but have idea that build definition does not available when
>>
>>   Contrib/Language files/*.nsh
>>
>> files processed. Is that true?
>>
>> "svn ann" shown first changes to this file by:
>>
>>   r5228 | joostverburg | 2007-08-09 04:12:21 +0300 (Thu, 09 Aug 2007) | 3 lines
>>
>>   New language files for localization of user interfaces and plug-ins.
>>   These files currently contain translations of the MUI and will be shared between different MUI versions.
>>
>> but I believe that this code introduced match early.
>>
>> In any case *then* and *else* leaves have duplicated text which all
>> translators also translate by same text (totally 62 duplications, I have only
>> brief look for text similarity and check only few cases literary).
>>
>> If anyone agree with me (that this condition is unnecessary) I remove it in
>> all language files...
>>
>> --
>> Best regards!
>>
>> ------------------------------------------------------------------------------
>> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
>> Remotely access PCs and mobile devices and provide instant support
>> Improve your efficiency, and focus on delivering more value-add services
>> Discover what IT Professionals Know. Rescue delivers
>> http://p.sf.net/sfu/logmein_12329d2d
>> _______________________________________________
>> Nsis-devel mailing list
>> Nsi...@li...
>> https://lists.sourceforge.net/lists/listinfo/nsis-devel