Menu

#547 System::Store l crash installer when private stack is empty

2.0 Series
closed-fixed
Plugin (101)
5
2006-12-22
2006-12-21
No

Version v2.21

Example code:

######################
Name InstTest
OutFile 'InstText.exe'

Section "Do something"

DetailPrint "Wizard is about to die"
System::Store "l"

SectionEnd
######################
######################
Name InstTest
OutFile 'InstText.exe'

Section "Do something"

DetailPrint "Ok here"
System::Store /NOUNLOAD "s"
DetailPrint "Ok here too"
System::Store "l"

DetailPrint "Wizard is about to die"
System::Store "l"

SectionEnd
######################

If you have not done a store then it crashes the whole installer.

I use store-s/store-l at the start of all my functions to protect all their internals. This behaviour means that I can not call functions from within functions.

At the very least it should stop with a clean error message. It should no just disappear without warning.

Discussion

  • Amir Szekely

    Amir Szekely - 2006-12-22

    Logged In: YES
    user_id=584402
    Originator: NO

    Thanks, fixed.

     
  • Amir Szekely

    Amir Szekely - 2006-12-22
    • labels: 732400 --> Plugin
    • summary: System::Store l crash installer when privatestack is empty --> System::Store l crash installer when private stack is empty
    • status: open --> closed-fixed
     

Log in to post a comment.