Menu

#439 Settings in HKLM instead of HKCU?

2.0 Series
closed-fixed
MakeNSISW (21)
5
2007-01-24
2006-01-22
No

Hi,

> #define REGSEC HKEY_LOCAL_MACHINE
> #define REGKEY "Software\\NSIS"

Why does NSIS use the read-only system-wide HKLM
instead of the per-user writable HKCU?

Discussion

  • Anonymous

    Anonymous - 2006-01-25

    Logged In: YES
    user_id=970495

    this is the normal behaviour of software that wants to be
    accessable for all users ...

     
  • Olaf van der Spek

    Logged In: YES
    user_id=30264

    No, it's not.
    Settings (like MakeNSISWCompressor and MakeNSISWPlacement)
    should be placed in HKCU.
    Otherwise, a user can't change them.

     
  • Anonymous

    Anonymous - 2006-01-25

    Logged In: YES
    user_id=970495

    why not submit a patch, that features both?

    so that HKLM is the default, while HKCU has higher priority?

     
  • Olaf van der Spek

    Logged In: YES
    user_id=30264

    Because I don't see the advantage of that way.

     
  • Amir Szekely

    Amir Szekely - 2007-01-24

    Logged In: YES
    user_id=584402
    Originator: NO

    The advantage is backwards compatibility. Old user settings will not be lost upon upgrade if HKLM is checked in case HKCU doesn't exist. I've implemented this behavior for the next version. Thanks.

     
  • Amir Szekely

    Amir Szekely - 2007-01-24
    • assigned_to: nobody --> kichik
    • status: open --> closed-fixed
     
  • Olaf van der Spek

    Logged In: YES
    user_id=30264
    Originator: YES

    Aren't the old user settings lost anyway because the uninstaller removes the key in HKLM?

     
  • Amir Szekely

    Amir Szekely - 2007-01-24

    Logged In: YES
    user_id=584402
    Originator: NO

    Not all users choose to uninstall the old version before installing the new one.

     

Log in to post a comment.