#1241 simplify signing uninstaller

[Gene Thomas]

Signing the uninstaller is a task any developer of credible software needs to do. The current solution https://nsis.sourceforge.io/Signing_an_Uninstaller uses 30 lines of code with if/elses that then over complicates the rest of the installer development. This really lets you down.

Could we have a command, say, !system-uninstaller, that is run with $UNINSTALLER set to the path of the uninstaller executable while building the installer. e.g:

!system-uninstaller 'signtool sign /tr http://timestamp.digicert.com /td sha256 /fd sha256 /f "my-certificte.p12" /p "my-password" "$UNINSTALLER"' = 0

Rather than the 30 lines of nsis script code in https://nsis.sourceforge.io/Signing_an_Uninstaller

[Jason]

I made a patch a while ago for nsis 3.03 for this very purpose, which I plan to update soon for 3.05 and probably change the name to !uninstfinalize.

https://sourceforge.net/p/nsis/patches/280/

[Roberto Bagnara]

Jason, an update of your patch would be very helpful, and I hope it will be merged into the source tree. I minimally adapted the patch so as to apply it to 3.05 and it works great. I attach it in case it may be of any use.

[Gene Thomas]

1. Is your patch likely to be included in a release soon?
2. If not could someone build a NSIS installer that includes the patch?
3. If not could someone tell me how to build the branch with the patch or
   how to apply the patch. I assume you are all using Visual Studio with C++?

Yours Gratefully,

Gene Thomas.

On Mon, 2 Mar 2020 at 09:08, Roberto Bagnara bagnara@users.sourceforge.net
wrote:

Jason, an update of your patch would be very helpful, and I hope it will
be merged into the source tree. I minimally adapted the patch so as to
apply it to 3.05 and it works great. I attach it in case it may be of any
use.

Attachments:

• 0001-nsis_uninst8.patch
  https://sourceforge.net/p/nsis/bugs/_discuss/thread/660b322983/d28b/attachment/0001-nsis_uninst8.patch
  (17.0 kB; text/x-patch)

---

• [bugs:#1241] https://sourceforge.net/p/nsis/bugs/1241/ simplify
  signing uninstaller*

Status: open
Group: 3.0 Series
Created: Fri Feb 28, 2020 02:31 AM UTC by Gene Thomas
Last Updated: Fri Feb 28, 2020 10:44 AM UTC
Owner: nobody

Signing the uninstaller is a task any developer of credible software needs
to do. The current solution
https://nsis.sourceforge.io/Signing_an_Uninstaller uses 30 lines of code
with if/elses that then over complicates the rest of the installer
development. This really lets you down.

Could we have a command, say, !system-uninstaller, that is run with
$UNINSTALLER set to the path of the uninstaller executable while building
the installer. e.g:

!system-uninstaller 'signtool sign /tr http://timestamp.digicert.com /td sha256 /fd sha256 /f "my-certificte.p12" /p "my-password" "$UNINSTALLER"' = 0

Rather than the 30 lines of nsis script code in
https://nsis.sourceforge.io/Signing_an_Uninstaller

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/nsis/bugs/1241/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

--
Gene Thomas

021 436384 http://genethomas.com
gene@genethomas.com

[Gene Thomas]

Jason,
Could you plese build a NSIS installer for Windows that I can use that includes the patch for !uninstfinalize and email it to me gene@genethomas.com , I would like do a release of my product this week.
Thanks in advance,
Gene Thomas.

[Matthew MacKenzie]

Hello--I would also love to be able to use this addition. I don't see it mentioned in any release notes. Will it be available soon? Thank you.

[Phillip Seaver]

I just found this, and this would make my script so much cleaner. Any chance of it making it into a release soon?

Thanks!

[Gene Thomas]

Can I second that, I'm doing the installer for another product and would love to make my uninstallation look professional without jumping through the hoops of the work-around https://nsis.sourceforge.io/Signing_an_Uninstaller . Surely any serious Nꜱɪꜱ user needs to sign their uninstaller.

[mailnew4ster]

I just had to do that, and it wasn't pleasant. I join the request.