Patches item #1644591, was opened at 2007-01-25 11:40
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=821570&aid=1644591&group_id=161868
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: Yes
Submitted By: Jamie McQuay (jamcquay)
Assigned to: Jamie McQuay (jamcquay)
Summary: Dirty Flag Optimization
Initial Comment:
Submitted via email from Pawel:
In several places (DoMouseDown(), DoMouseWheel(), DoMouseMove()) you
have taken over my suggestion to loop the interactions collecting the
'dirty' flag, however, you still keep the call throwing away the return
value. I do not understand why. It is not only less efficient (every
interaction called twice), but also changes the semantics: the first
call may make the surface dirty, while the second with the same
arguments is no-op, then the 'dirty' flag will not be set. If for any
reason you have to call interactions twice, it is better to reverse the
call or to collect the 'dirty' flag on both calls.
The last question is about MouseWheelZoom interaction. In the method
DoMouseWheel() you do not use
(float)SystemInformation.MouseWheelScrollDelta value to calculate the
scroll delta. Why? Is it because it is not available in .NET 1.1? If
so please keep in mind that the default value is 3.0 (settable in the
Control Panel).
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=821570&aid=1644591&group_id=161868
|
