Re: [Npfs-devel] two patches

[Latchesar I. <lu...@io...>]

If path has more than MAXWELEM it will be valid and has to be clunked.

Thanks,
    Lucho

On Mon, Feb 15, 2010 at 6:26 PM, Tim Newsham <tim...@gm...> wrote:
> http://plan9.bell-labs.com/magic/man2html/5/walk says that the fid is only
> valid if the
> walk returns an array of qid's that is the same length as the array of path
> components
> you passed in. It doesn't return an error (Rerror) but the fid is still not
> valid.  You'll
> see in traces talking to plan9 fileservers that if you use npc_walk (ie.
> from npc_open)
> on a file that doesnt exist, it will walk most of the way, return success,
> then do a
> Tclunk which will fail saying that the fid doesn't exist.
>
> On Mon, Feb 15, 2010 at 3:01 PM, Latchesar Ionkov <lu...@io...> wrote:
>>
>> Ack for the first patch.
>>
>> The fid needs to be clunked if there is a partial success while
>> walking. For example, if Twalk tries to walk four wnames and only
>> three succeed, the fid is valid and should be clunked because we don't
>> return it when we exit from the function.
>>
>> Thanks,
>>    Lucho
>>
>> On Mon, Feb 15, 2010 at 1:50 PM, Tim Newsham <tim...@gm...>
>> wrote:
>> > Two patches attached for approval:
>> >    - emptystat.patch adds the unspecified value for the group.  I forgot
>> > to
>> > add it earlier
>> >    - walkerr.patch removes the clunk that walk does when an error
>> > happens.
>> >      All paths to error happen when no new fid was opened so the clunk
>> > is
>> >      extraneous and only serves to ruin the stored error code.
>> >      (Note: fid is only opened when the walk completely walks all path
>> > components).
>> >
>> > --
>> > Tim Newsham | www.thenewsh.com/~newsham | thenewsh.blogspot.com
>> >
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > SOLARIS 10 is the OS for Data Centers - provides features such as
>> > DTrace,
>> > Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
>> > http://p.sf.net/sfu/solaris-dev2dev
>> > _______________________________________________
>> > Npfs-devel mailing list
>> > Npf...@li...
>> > https://lists.sourceforge.net/lists/listinfo/npfs-devel
>> >
>> >
>
>
>
> --
> Tim Newsham | www.thenewsh.com/~newsham | thenewsh.blogspot.com
>
>