#603 Added Incremental Search Next and Previous Shortcut Mappings

[Michael]

I added the ability to set a shortcut mapping for the incremental search's find next find previous functions.

One thing I did notice is that shortcuts do not get processed when a dialog has focus like the find dialog or incremental search dialog. So if you hit ctrl-f to do a search and then hit f3 to find next, it does not work unless you first click inside the main editor for it to get focus. This is caused by the code in winmain.cpp, that ignores accelerators if the message is for a dialog "if (!notepad_plus_plus.isDlgsMsg(&msg)". It would be less frustrating and more consistent with other programs if accelerators were processed even when the dialog has focus. The patch does not include any fix for this issue. It just adds the shortcuts.

[Mike Cowperthwaite]

To be clear: For incremental search, even if you click inside the window, F3 (or whatever your mapping is, I use Ctrl+] ) won't find the next instance of the incrementally-searched item; that string is not made part of the search history. Your patch addresses this by adding new commands to repeat the incremental search, but those still require different hotkeys than the normal find-next/prev.

As you say, this is a different problem from the one of the "expected" hotkeys not working from within the dialogs.

What I would really like is for the incremental search dialog, especially, to not only support next and previous shortcuts, but to dynamically use the next/prev hotkeys assigned to Find Next & Find Previous.

[Michael]

This patch is no longer needed with Mike Cowperthwaite's incremental search improvement patches in #615

[Don HO]

Incremental search will use F3 and Shift-F3 for searching next and previous respectively in the next release.

Thank you for your patch anyway.

Don