Help save net neutrality! Learn more.
Close

#482 Fix for bugs #2441, #2585, #2889 and #3396 (Aero-snapped window restoring to normal size when opening another file)

Next_major_release
closed
nobody
None
7
2014-02-18
2013-06-02
Ede_123
No

This patch solves the bug reported in [#2441], [#2585], [#2889] and [#3396] (when using Aero-snap the Aero-snapped window restores to it's initial position as soon as another file is opened).

Actually this patch is the same as [patches:#436] which you initially closed in error and probably forgot to reopen so you might not receive any notifications about it anymore (which is why I created a new patch).
This patch was confirmed working independently by two people in [#3396] whom I provided a patched build of Notepad++ 6.3.3 as well as Pekka Pöyry in the old patch artifact in the meantime, so I think we can rule out an error on my side.
Personally I'm using this patch for over half a year now and I applied it to every version of Notepad++ since 6.2.2 without noticing any problem so far.

1 Attachments

Related

Bugs: #2441
Bugs: #2585
Bugs: #2889
Bugs: #3396
Patches: #436

Discussion

  • Ben Humberston

    Ben Humberston - 2013-06-06

    Working well on Windows 7 x64. No problems or other side-effects so far and it fixed my one major annoyance with NP++.

     
  • Ian Channing

    Ian Channing - 2013-06-07

    Installed this patch on 26th May 2013. It both fixes the problem and hasn't cause any other problems. Windows 7 x64, v6.3.3.

     
  • Don HO

    Don HO - 2013-08-05

    I tried it again.
    This patch seems work for everyone, except me.

    It's not possible to me to include a "fix" which fixes nothing to me. Sorry for that.

    Don

     
  • Don HO

    Don HO - 2013-08-05
    • status: open --> closed
    • Priority: 5 --> 1
     
  • Ede_123

    Ede_123 - 2013-08-05

    Sorry Don, I'm still afraid you're using this patch wrong, therefore you think it does not work for you.

    This patch does not work if it is in a debug build of yours!
    This patch does work if is in the Notepad++ executable that is associated to the various file extensions in your system or the context menu.

    Therefore you must place the patched executable in the folder where you installed Notepadd++ via the installer (therefore typically "C:\Program Files\Notepad++\notepad++.exe")

    Please try this! It works and it will make a lot of people (including me ;) ) very happy. I'm tired of maintaining my own build just for such a trivial fix.

     
  • Don HO

    Don HO - 2013-08-06

    I did all you described (including bulding the release binary and copying into its installed dir) under my windows 7 64 bits laptop, your patch does not work at all.

    I now do the same on my Windows 8 32 bits machine, your patch works.

    Doesn't this patch work on Windows 7 or it's my windows 7's problem?

    Don

     
  • Ede_123

    Ede_123 - 2013-08-06

    I use this patch on Windows 7 Professional (x64), so no, it should work on Windows 7, too.

    Is it a caching issue (e.g. old executable in memory)? Or is there something in your Windows 7's "Virtual Store" shadowing the correct executable?

     
  • Ian Channing

    Ian Channing - 2013-08-06

    I'm also using this patch on Windows 7 Professional (x64) and its been working fine.

     
  • Don HO

    Don HO - 2013-08-06
    • status: closed --> accepted
    • Priority: 1 --> 7
     
  • Don HO

    Don HO - 2013-08-06

    I did some tests under xp and windows 8 - it seems no regression to me.
    Committed in SVN (rev. 1099) and il will be in the next version.

    Thank you for your fix (and your insistence :) ).

    Don

     
    Last edit: Don HO 2013-08-06
  • Ede_123

    Ede_123 - 2013-08-06

    Great! Finally the change made it into SVN.

    Thank you Don.

     
  • Don HO

    Don HO - 2013-08-29
    • status: accepted --> closed