Menu

#256 report on application of prior save all patch

open
nobody
None
5
2012-11-13
2010-09-28
David
No

RE: SAVE ALL patch - ID: 3021529

Don the number of checkDocState() function calls added appear to be insufficient from this initial patch. I run a modified version of notepad++ with a custom lexer I wrote that was not accepted as part of scintilla. I downloaded the current version (svn) of notepad this weekend and left out my additions of checkDocState() in the NPPCommands.cpp code. Today I did a save all from a tab that did not need to be saved (others did I believe), The Save All menuitem was not disabled as a result of clicking save all. It was disabled when I changed tabs. I have added my list back in for further testing with this new version.

Discussion