Menu

#3 Off-by-one progress update in playlist

open
Download (2)
5
2002-09-17
2002-09-17
Anonymous
No

In the nomadii util, the progress update is initialized
with the wrong upper limit during playlist loading.
Thus, status messages are misleading -- implying that
an extra track is due to be loaded onto the player.

Please apply the following diff as time permits. Thanks.

--- bhw (brian@glyphrider.org)

Index: commands.c

RCS file: /cvsroot/nomadii/nomadii/commands.c,v
retrieving revision 1.11
diff -r1.11 commands.c
1226c1226
< progress_handler(NOMADII_PROGRESS_RESET, total, NULL);
---
> progress_handler(NOMADII_PROGRESS_RESET, total - 1, NULL);

Discussion

  • Brian H. Ward

    Brian H. Ward - 2002-09-17

    Logged In: YES
    user_id=612578

    Sorry I wasn't logged in when I posted this....

     
  • Neil Hodge

    Neil Hodge - 2002-09-17
    • assigned_to: nobody --> tmander
     
  • Tom Mander

    Tom Mander - 2002-10-24

    Logged In: YES
    user_id=454276

    It isn't actually quite this simple. It it currently right
    for some cases, but not all. I then made a fix a while back
    that fixed that case, but stuffed up another case. Just
    silly obiwan (out by one) errors - I'll try and get to this
    soon.

     

Log in to post a comment.

MongoDB Logo MongoDB