Re: [Noffle-devel] Newsgroup line missing

[Jim H. <jim...@ac...>]

On 13-Mar-2002 Mirko Liss wrote:
> Jim Hague wrote:
>> On 13-Mar-2002 Mirko Liss wrote:
>> > Mardy wrote:
>> > [..bogus headers in online mode..]
>> >> I suspect that slrn caches some info...
>> > No, it's a bug of noffle/src/server.c:doArtInDb().
> 
>> I think we need to break out the online mode code that determines if the
>> article is retrieved and retrieves it if not, and call that in doHeadInDb()
>> as well as in doBodyInDb().
> 
> Yes. I'll fix the bug in the cvs.

>> Plus doHeadInDb() should mark the article and references as 'interesting' as
>> well.
> 
> No, please don't. That defuncs the subscription modes 'thread' and 'over',
> doesn't it? Some newsreaders ignore XOVER and send lots of HEAD commands.
> 
> E.g. pine gives HEAD and slrn does the same if you mention non-overview
> headers in the ~/News/Score file. XOVER is just an ugly NNTP hack from an
> informational rfc, after all.
> 
> The ARTICLE and BODY commands mark an article as interesting, but HEAD
> doesn't.

Duh. I'd forgotten about that usage of HEAD.

OK, so HEAD definitely shouldn't cause an article to be retrieved or marked as
interesting. In which case, what should happen here is that

    if ( Online_true() && ( stat & DB_NOT_DOWNLOADED ) )
    {
        retrieveArt( msgId );
        stat = Db_status( msgId );
    }

should come out of doBodyInDb() and go into doBody() and doArt(). Yes?

-- 
Jim Hague - jim...@in... (Work), ji...@be... (Play)
Never trust a computer you can't lift or you don't control.