On Sun, May 18, 2003 at 10:36:47AM +0100, Neil Williams wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Line 465 in the parse_message_list subroutine:
>
> if (/<!--top: (\d+)--><li><a href="[^"]+">(.*)<\/a> -
> <b>(.*)<\/b>\s+<i>(.*)<\/i>/) {
>
> (line break added by mail client)
>
> The original line above doesn't catch all messages. There needs to be an
> optional match for a preceding </li> tag after the top comment:
> <!--top: (\d+)--><li>
> needs to be:
> <!--top: (\d+)-->[<\/li>]+<li>
>
> The full line then becomes:
>
> if (/<!--top: (\d+)-->[<\/li>]+<li><a href="[^"]+">(.*)<\/a> -
> <b>(.*)<\/b>\s+<i>(.*)<\/i>/) {
>
> I had a number of messages that could not be removed by wwwadmin because the
> message never showed up. All messages shown by wwwadmin must parse this
> statement but an additional </li> for some messages was causing the match to
> fail.
Good work, thanks.
I've made the change and released wwwboard 1.51.24.
I used (?:</li>)? rather than [<\/li>]+, to limit the extra text matched
to exactly </li>.
Thanks again for your help.
--
Nick
|