nms-cgi-devel — Developers discussion for NMS CGI programs

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
search search.html,1.1.1.1,1.2
Wed Nov 14 14:46:59 PST 2001
Update of /cvsroot/nms-cgi/search
In directory usw-pr-cvs1:/tmp/cvs-serv30162/search

Modified Files:
	search.html 
Log Message:
XHTML 1.0 Transitional.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
rand_link rand_link.html,1.1.1.1,1.2
Wed Nov 14 14:46:59 PST 2001
Update of /cvsroot/nms-cgi/rand_link
In directory usw-pr-cvs1:/tmp/cvs-serv30162/rand_link

Modified Files:
	rand_link.html 
Log Message:
XHTML 1.0 Transitional.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
ffa links.html,1.4,1.5
Wed Nov 14 14:46:58 PST 2001
Update of /cvsroot/nms-cgi/ffa
In directory usw-pr-cvs1:/tmp/cvs-serv30162/ffa

Modified Files:
	links.html 
Log Message:
XHTML 1.0 Transitional.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
countdown countdown.html,1.1.1.1,1.2
Wed Nov 14 14:46:58 PST 2001
Update of /cvsroot/nms-cgi/countdown
In directory usw-pr-cvs1:/tmp/cvs-serv30162/countdown

Modified Files:
	countdown.html 
Log Message:
XHTML 1.0 Transitional.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
wwwboard README,1.1.1.1,1.2
Wed Nov 14 14:21:18 PST 2001
Update of /cvsroot/nms-cgi/wwwboard
In directory usw-pr-cvs1:/tmp/cvs-serv23020/wwwboard

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
textcounter README,1.1.1.1,1.2
Wed Nov 14 14:21:18 PST 2001
Update of /cvsroot/nms-cgi/textcounter
In directory usw-pr-cvs1:/tmp/cvs-serv23020/textcounter

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
ssi_rand_image README,1.1.1.1,1.2
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/ssi_rand_image
In directory usw-pr-cvs1:/tmp/cvs-serv23020/ssi_rand_image

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
search README,1.1.1.1,1.2
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/search
In directory usw-pr-cvs1:/tmp/cvs-serv23020/search

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
textclock README,1.1.1.1,1.2
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/textclock
In directory usw-pr-cvs1:/tmp/cvs-serv23020/textclock

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
rand_text README,1.1.1.1,1.2
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/rand_text
In directory usw-pr-cvs1:/tmp/cvs-serv23020/rand_text

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
rand_link README,1.1.1.1,1.2
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/rand_link
In directory usw-pr-cvs1:/tmp/cvs-serv23020/rand_link

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
formmail README,1.1.1.1,1.2
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/formmail
In directory usw-pr-cvs1:/tmp/cvs-serv23020/formmail

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
guestbook README,1.1.1.1,1.2 guestbook.pl,1.4,1.5
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/guestbook
In directory usw-pr-cvs1:/tmp/cvs-serv23020/guestbook

Modified Files:
	README guestbook.pl 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
countdown README,1.1.1.1,1.2
Wed Nov 14 14:21:16 PST 2001
Update of /cvsroot/nms-cgi/countdown
In directory usw-pr-cvs1:/tmp/cvs-serv23020/countdown

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
imagecounter README,1.1.1.1,1.2
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/imagecounter
In directory usw-pr-cvs1:/tmp/cvs-serv23020/imagecounter

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
ffa README,1.2,1.3
Wed Nov 14 14:21:16 PST 2001
Update of /cvsroot/nms-cgi/ffa
In directory usw-pr-cvs1:/tmp/cvs-serv23020/ffa

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
rand_image README,1.1.1.1,1.2
Wed Nov 14 14:21:17 PST 2001
Update of /cvsroot/nms-cgi/rand_image
In directory usw-pr-cvs1:/tmp/cvs-serv23020/rand_image

Modified Files:
	README 
Log Message:
Changed script archive URL to Sourceforge.
Added link to support mailing list.

Re: [Nms-cgi-devel] Further Updates to countdown.pl

[Joseph F. R. <rya...@os...>]

Hi.  In response to Jonathan:

>You don't need to change the Shebang for IIS - of course you might do if
>you are running these with Apache on windows which fakes up the Unix
>execvp behaviour but uses the path.

Yeah, I was running Apache under windoze (I am on that boot a lot of the 
time because I am a Starcraft addict ;)

>Bloody did! ;-}
>
>I have tested this code:
>
>#!/usr/bin/perl -w
>
>use strict;
>
>use CGI;
>use CGI::Carp qw(fatalsToBrowser set_message);
>use vars qw($DEBUGGING);
>
>#
># $DEBUGGING must be set in a BEGIN block in order to have it be set before
># the program is fully compiled.
># This should almost certainly be set to 0 when the program is 'live'
>#
>
>BEGIN
>{
>    $DEBUGGING = 0;
>}
>
>BEGIN
>{
>    my $error_message = sub {
>                              my ($message ) = @_;
>                              print "<h1>It's all gone horribly wrong</h1>";
>                              print $message if $DEBUGGING;
>                             };
>
>   set_message($error_message);
>}
>
>
>die "Wahay!\n";

Hehe, that wasn't what you sent :)

Here is what I got:

 >use CGI::Carp qw(fatalsToBrowser set_message);
 >use vars qw($DEBUGGING);
 >BEGIN
 >{
 >$DEBUGGING = 1;
 >$error_handler = sub
 >{
 >my ($mesg) = @_;
 >print "text/html\n\n";
 >print "<strong>Something nasty happened</strong>";
 >print "Perl said : $message" if $DEBUGGING;
 >}
 >set_message($error_handler);
 >}

That has a few syntax errors in it, these two lines most blatently:
my ($mesg) = @_; # should be: my $message = shift; since you used $message 
later on :)
print "text/html\n\n"; #forgot Content-type:!  iti sn't even needed, however...

No worries, at any rate. :)  I have a better idea (2 of em actually):
1:
----------

BEGIN {

# **** Configuration ****

# @from_date = (yyyy,mm,dd,hh,mm,ss);
# Which means: (year,month,day,hour,minute,second)
@from_date = (2002,9,7,0,0,0); # the default date to find the difference from
$delimiter = "&nbsp;";         # what gets printed between output.
$DEBUGGING = 1;                # set to 1 to turn on debugging mode, 0 to 
turn it off (recommended)

# **** End configuration ****

eval ("use CGI::Carp qw(fatalsToBrowser)") if $DEBUGGING;

----------
This would load CGI::Carp only on demand; The user gets a standard 500 
error if debugging is turned off, and fatalsToBrowser if not.  However, 
this still suffers from the same problem as before; if there is an error in 
the config, the standard 500 error gets shoved out.  This, however, does not:
2:
----------

use CGI::Carp qw(fatalsToBrowser set_message);
BEGIN {set_message(sub{print"[Error in Script Setup Config]"})}
BEGIN {

# **** Configuration ****

# @from_date = (yyyy,mm,dd,hh,mm,ss);
# Which means: (year,month,day,hour,minute,second)
@from_date = (2002,9,7,0,0,0); # the default date to find the difference from
$delimiter = "&nbsp;";         # what gets printed between output.
$DEBUGGING = 1;                # set to 1 to turn on debugging mode, 0 to 
turn it off (recommended)

# **** End configuration ****

set_message(sub{print"[Error]"})if!$DEBUGGING;
set_message("")if$DEBUGGING;
}

----------

This will not only handle errors in the config section, but allow us to 
state that the error is specifically in the startup section.  However, it 
suffers from the drawback of not using the standard 500 error.  <babble 
type="mindless">Perhaps we could pipe in the error message from a dummy 
script through a system call and then... *inane babble continues*</babble>

>This code is basically shorthand for a larger nicer error message that is
>fit to be presented to the punters - I am waiting for someone who can be
>arsed with making nice HTML to do that.

Hey, I was primarily a web designer for about 6 years before moving on to 
grander things.  What exact did you have in mind? I'm not half bad, if I do 
say so myself!

>You need to be able to access the CVS - we can discuss working with CVS if
>you are unfamiliar with this.

Yeah, I haven't the slightest clue what CVS is, other than an overpriced 
drug store chain.  I would be greatful if you were to enlighten me :)


In response to Dave:

 >Note that I've added parens around the lists. This solves the problem
 >quite well. The script needs some other changes so that it doesn't cause
 >so many warnings when values aren't initialised, but that's an exercise
 >for the reader?
 >So, um, does someone want to make the appropriate changes to the CVS
 >version and announce a bug fix to Wayne?

Yeah, I'll start on that tonight (plus give it a good fixen) after my calc 
midterm.  Speaking of that... I am running a bit late, gotta go :)

Re: [Nms-cgi-devel] Further Updates to countdown.pl

[Jonathan S. <gel...@ge...>]

On Tue, 13 Nov 2001, ryan.311 wrote:

> Hey guys, sorry I haven't been responding in a while; I've been busy.
> Anyways, here are some thoughts:
>
>  >You also changed the shebang line to #!perl -wT. We need to agree on a
>  >standard for shebang lines, but it'll probably be #!/usr/bin/perl -wT
>
> Well, I was under NT when I was running it... I changed it when I uploaded
> it this time.  Apologies!
>

You don't need to change the Shebang for IIS - of course you might do if
you are running these with Apache on windows which fakes up the Unix
execvp behaviour but uses the path.

I am going to do up the FAQ about running this stuff nicely on Windows - I
am having an enforced refamilarisation with it right now :)


>
>  >I don't agree with having use CGI::Carpi qw(fatalsToBrowser) in production
>  >code. It gives too much information to anyone trying to crack the site. The
>  >standard CGI error message is vague for a good reason. The full error
>  >messsage is written to the server error log where the webmaster can read
>  >it. By all means add it to the code - but comment it out in released
>  >versions.
>
> I thought Jonathan's idea of using CGI::Carp's set_message function was an
> excellent idea.
> However, the code snippet he provided didn't work ;)  I changed it to this:
>
> BEGIN{set_message(sub{print"[Error]"})if!$DEBUGGING;}
>

Bloody did! ;-}

I have tested this code:

#!/usr/bin/perl -w

use strict;

use CGI;
use CGI::Carp qw(fatalsToBrowser set_message);
use vars qw($DEBUGGING);

#
# $DEBUGGING must be set in a BEGIN block in order to have it be set before
# the program is fully compiled.
# This should almost certainly be set to 0 when the program is 'live'
#

BEGIN
{
   $DEBUGGING = 0;
}

BEGIN
{
   my $error_message = sub {
                             my ($message ) = @_;
                             print "<h1>It's all gone horribly wrong</h1>";
                             print $message if $DEBUGGING;
                            };

  set_message($error_message);
}


die "Wahay!\n";


Which is the boilerplate for what I have placed in all the programs and
some stuff to make it work and it works fine for me with perl 5.6.1.

It might be that some construct I am using doesnt extend back all the way
to 5.004.04 here  but the only diff I can see between what you are doing
and I am doing is the anonymous subroutine and I can't believe that that
hasnt been around since we we have had references (in 5.001m ?)

This code is basically shorthand for a larger nicer error message that is
fit to be presented to the punters - I am waiting for someone who can be
arsed with making nice HTML to do that.

Obviously if one was in control of the server itself one would configure
it so that the '500' status page was nice enough that you could just let
programs die.

> That will output "[Error]" whenever there is an error in the script when
> $DEBUGGING is set to 0.
> However, if there is an error earlier in the BEGIN statement, CGI::Carp
> will output errors regardless
> of what $DEBUGGING is set to.
>

Well yes, there is almost certainly nothing we could do to prevent error
leakage at some point - we just need to endeavour to reduce the
possibility of that ... unfortunately the configuration of the server is
going to cause the program to fail before compilation.  Thats the shit ;-}

<snip>

>
> Ugh... Fine.  I added support for both ways, however:
>

Er.. I'll start a new thread ;-}

>
> Secondly, I am not sure how to upload on sourceforge.  For the time being,
> I re-uploaded to jcwren's server (http://jryan.perlmonk.org/nms/countdown.txt).
>

You need to be able to access the CVS - we can discuss working with CVS if
you are unfamiliar with this.

> Thirdly, I have two midterms coming up over the next two days, so my time
> for NMS will be limited until my midterms are over.  I should be able to
> thoroughly look over another script during that time, however, so
> suggestions for the next script to pick apart are welcome.
>

Hey, I have to give annual reviews to two of my little helpers and ensure
that the four projects we are working on are on track, integrate two
billing systems that exist in our German operation and propose the
architecture for the european rollout of two software systems ;-}

And that is this week ;-}

This is volunteer stuff matey don't worry ...


/J\
-- 
Jonathan Stowe                      |
<http://www.gellyfish.com>          |      This space for rent
                                    |

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
guestbook guestbook.html,1.1.1.1,1.2 guestlog.html,1.1.1.1,1.2
Wed Nov 14 11:43:23 PST 2001
Update of /cvsroot/nms-cgi/guestbook
In directory usw-pr-cvs1:/tmp/cvs-serv9327

Modified Files:
	guestbook.html guestlog.html 
Log Message:
XHTML 1.0 Transitional

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
guestbook guestbook.pl,1.3,1.4
Wed Nov 14 11:39:14 PST 2001
Update of /cvsroot/nms-cgi/guestbook
In directory usw-pr-cvs1:/tmp/cvs-serv8029

Modified Files:
	guestbook.pl 
Log Message:
Fixed stupid bug getting CGI parameters

[Nms-cgi-devel] CVS Commit %s

[Dave C. <da...@us...>]

uid=38988(davorg) gid=100(users) groups=100(users),14388(insect),40625(nms-cgi)
guestbook addguest.html,1.1.1.1,1.2
Wed Nov 14 11:38:15 PST 2001
Update of /cvsroot/nms-cgi/guestbook
In directory usw-pr-cvs1:/tmp/cvs-serv7772

Modified Files:
	addguest.html 
Log Message:
XHTML 1.0 Transitional

Re: [Nms-cgi-devel] CVS Commit %s

[Jonathan S. <gel...@ge...>]

On Wed, 14 Nov 2001, Jonathan Stowe wrote:

>
> uid=68026(gellyfish) gid=100(users) groups=100(users),40625(nms-cgi)
> formmail FormMail.pl,1.4,1.5

Wahay, it works!

/J\
-- 
Jonathan Stowe                      |
<http://www.gellyfish.com>          |      This space for rent
                                    |

CGI::Carp version (was Re: [Nms-cgi-devel] Welcome)

[Jonathan S. <gel...@ge...>]

On Tue, 13 Nov 2001, Dave Cross wrote:
>
> I'll see if I can find out which version of CGI and CGI::Carp shipped with
> Perl 5.004_04.
>

According to the Changes5.004 in the Perl distribution the version of
CGI.pm was 2.32 and it was added in 5.003_96, the set_message(CODEREF)
feature was added in version 1.09 of CGI::Carp and the current version is
1.20 which appears not have been changed since 1998 - empirically I would
say we are safe but someone might want to check it on a machine with
5.00404.

/J\
-- 
Jonathan Stowe                      |
<http://www.gellyfish.com>          |      This space for rent
                                    |

[Nms-cgi-devel] FormMail and spam

[Jonathan S. <gel...@ge...>]

Over the next while I am going to put in a number of potentially
incompatible-with-matts-code changes into FormMail.pl that are designed to
prevent as far as possible someone who installs this program becoming the
unwitting pawn of spammers.  These are switched on by setting $secure in
the configuration - setting $emulate_matts_code will switch them off -
there should be a caveat in the documentation.

The first change I have here is to compare the actual IP of the referering
host with any IP numbers in @referers - the aim of this is to encourage
people to use this check where it would otherwise be difficult (say in a
shared hosting environment where one script is used by multiple virtual
hosts).  I am quite aware that the referer is trivially spoofed if one is
creating ones own HTTP request however this check is probably sufficient
to prevent the more naive attempts to use the program as an anonymous
mailer.

The code I have put in is only a suggestion - if anyone has a better
implementation then feel free to fix them.

/J\
-- 
Jonathan Stowe                      |
<http://www.gellyfish.com>          |      This space for rent
                                    |