|
From: Joseph F. R. <rya...@os...> - 2002-01-28 23:12:25
|
First of all, I don't think that we should change config variables to
constants. The original MWS didn't use constants as the config, and I
don't think we should either. It provides no further benefit for the
program, and it could only lead to confusion when a non-perl programmer
tries to edit the config.
Secondly, the use of subs to create constants like that is ridiculous. Try
the constant pragma :)
use constant DEBUGGING => 0;
use constant EMULATE_MATTS_CODE => 0;
use constant MAILPROG => '/usr/lib/sendmail -oi -t';
Joseph Ryan
At 05:37 PM 1/28/2002 -0500, Olivier Dragon wrote:
>On Mon, Jan 28, 2002 at 09:39:26PM +0000, Jonathan Stowe wrote:
> > In the first place I really am not going to be the
> > one who goes through the code altering the places where these variables
> > are interpolated into quoted strings, which really would mean assigning
> > their values to new variables rather than some @{[EMULATE_MATTS_CODE()]}
> > hack ... and then there is the documentation and the support issues :)
>
>I've (in a subtle way maybe) proposed myself to do it, in which case the
>"it's a lot of work" argument doesn't really hold for anybody but me
>(unless someone would like to help) and since I'm in favor of the
>change, the argument isn't really *against* anything.
>
>-Oli
>
>--
>+----------------------------------------------+
>| Olivier Dragon dr...@sh... |
>| Software Engineering II, McMaster University |
>+----------------------------------------------+
>
>_______________________________________________
>Nms-cgi-devel mailing list
>Nms...@li...
>https://lists.sourceforge.net/lists/listinfo/nms-cgi-devel
|